[webkit-changes] [WebKit/WebKit] fd1445: [scroll-animations] WPT test `scroll-animations/sc...

[Antoine Quint]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fd1445729caf95b02bc8f55b1e1ff049bde6c40f
      https://github.com/WebKit/WebKit/commit/fd1445729caf95b02bc8f55b1e1ff049bde6c40f
  Author: Antoine Quint <graouts at webkit.org>
  Date:   2024-10-18 (Fri, 18 Oct 2024)

  Changed paths:
    M LayoutTests/TestExpectations
    M LayoutTests/imported/w3c/web-platform-tests/scroll-animations/scroll-timelines/setting-timeline.tentative-expected.txt
    M Source/WebCore/animation/KeyframeEffect.cpp
    M Source/WebCore/animation/KeyframeEffect.h
    M Source/WebCore/animation/WebAnimation.cpp

  Log Message:
  -----------
  [scroll-animations] WPT test `scroll-animations/scroll-timelines/setting-timeline.tentative.html` is a crash
https://bugs.webkit.org/show_bug.cgi?id=281741
rdar://138178537

Reviewed by Anne van Kesteren.

There were two issues in this test:

1. we would attempt to run an accelerated effect for an animation associated with a
progress-based timeline, which we simply do not support,
2. we would cache the end time of an animation under `setTimeline()` which lead to
incompatible time values as the timeline would switch between progress-based and
monotonic timelines.

* LayoutTests/TestExpectations:
* LayoutTests/imported/w3c/web-platform-tests/scroll-animations/scroll-timelines/setting-timeline.tentative-expected.txt:
* Source/WebCore/animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::animationTimelineDidChange):
(WebCore::KeyframeEffect::canBeAccelerated const):
* Source/WebCore/animation/KeyframeEffect.h:
* Source/WebCore/animation/WebAnimation.cpp:
(WebCore::WebAnimation::setTimeline):

Canonical link: https://commits.webkit.org/285396@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications