[webkit-changes] [WebKit/WebKit] 4cb42b: Enhanced <input type=color>: make a11y code accoun...

Anne van Kesteren noreply at github.com
Fri Oct 18 05:23:00 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4cb42b8c9386d435841b39b4864d920ee9416c03
      https://github.com/WebKit/WebKit/commit/4cb42b8c9386d435841b39b4864d920ee9416c03
  Author: Anne van Kesteren <annevk at annevk.nl>
  Date:   2024-10-18 (Fri, 18 Oct 2024)

  Changed paths:
    M LayoutTests/accessibility/color-well-expected.txt
    A LayoutTests/accessibility/color-well-legacy-expected.txt
    A LayoutTests/accessibility/color-well-legacy.html
    M LayoutTests/accessibility/color-well.html
    M LayoutTests/platform/glib/TestExpectations
    R LayoutTests/platform/gtk/accessibility/color-well-expected.txt
    A LayoutTests/platform/gtk/accessibility/color-well-legacy-expected.txt
    M LayoutTests/platform/mac-wk1/TestExpectations
    R LayoutTests/platform/wpe/accessibility/color-well-expected.txt
    A LayoutTests/platform/wpe/accessibility/color-well-legacy-expected.txt
    M Source/WebCore/accessibility/AXCoreObject.cpp
    M Source/WebCore/accessibility/AccessibilityNodeObject.cpp
    M Source/WebCore/accessibility/AccessibilityObject.cpp
    M Source/WebCore/html/HTMLInputElement.cpp

  Log Message:
  -----------
  Enhanced <input type=color>: make a11y code account for alpha
https://bugs.webkit.org/show_bug.cgi?id=281283
rdar://137734496

Reviewed by Tyler Wilcock.

Change the fallback color from transparent black to opaque black to
preserve how it is exposed today in accessibility. This also happens to
match the fallback color used by the control itself. It is not entirely
clear why transparent black was used before.

And start serializing the alpha component of the color in
AXCoreObject::value() when it is not 1. As all existing code paths can
only hit it when it is 1 there is no preference guard here.

* LayoutTests/accessibility/color-well-expected.txt:
* LayoutTests/accessibility/color-well-legacy-expected.txt: Copied from LayoutTests/accessibility/color-well-expected.txt.
* LayoutTests/accessibility/color-well-legacy.html: Copied from LayoutTests/accessibility/color-well.html.
* LayoutTests/accessibility/color-well.html:
* LayoutTests/platform/glib/TestExpectations:
* LayoutTests/platform/gtk/accessibility/color-well-legacy-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/color-well-expected.txt.
* LayoutTests/platform/mac-wk1/TestExpectations:
* LayoutTests/platform/wpe/accessibility/color-well-legacy-expected.txt: Renamed from LayoutTests/platform/wpe/accessibility/color-well-expected.txt.
* Source/WebCore/accessibility/AXCoreObject.cpp:
(WebCore::AXCoreObject::value):
* Source/WebCore/accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::colorValue const):
* Source/WebCore/accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::colorValue const):
* Source/WebCore/html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::valueAsColor const):

Canonical link: https://commits.webkit.org/285395@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list