[webkit-changes] [WebKit/WebKit] ed0306: Remove ColorInputType::typeMismatchFor

Anne van Kesteren noreply at github.com
Thu Oct 17 13:10:14 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ed03064672f5ea487f64465c2f35a9f59b2d5a40
      https://github.com/WebKit/WebKit/commit/ed03064672f5ea487f64465c2f35a9f59b2d5a40
  Author: Anne van Kesteren <annevk at annevk.nl>
  Date:   2024-10-17 (Thu, 17 Oct 2024)

  Changed paths:
    M Source/WebCore/html/ColorInputType.cpp
    M Source/WebCore/html/ColorInputType.h

  Log Message:
  -----------
  Remove ColorInputType::typeMismatchFor
https://bugs.webkit.org/show_bug.cgi?id=281620
rdar://138062947

Reviewed by Wenson Hsieh.

110431 at main added this for the benefit of filtering <datalist>
suggestions, but these days that is handled by
ColorInputType::suggestedColors which directly parses the result into a
color and therefore takes care of the validation.

And <input type=color> always has a valid value, except when a custom
error is used. So this is not used for that either.

* Source/WebCore/html/ColorInputType.cpp:
(WebCore::ColorInputType::typeMismatchFor const): Deleted.
* Source/WebCore/html/ColorInputType.h:

Canonical link: https://commits.webkit.org/285356@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list