[webkit-changes] [WebKit/WebKit] 7098ad: [TZone] Update TZone debugging code

[Michael Saboff]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7098ad895d64acbb6fae3637fbc72cc53f777300
      https://github.com/WebKit/WebKit/commit/7098ad895d64acbb6fae3637fbc72cc53f777300
  Author: Michael Saboff <msaboff at apple.com>
  Date:   2024-10-17 (Thu, 17 Oct 2024)

  Changed paths:
    M Source/bmalloc/bmalloc/TZoneHeap.h
    M Source/bmalloc/bmalloc/TZoneHeapManager.cpp
    M Source/bmalloc/bmalloc/TZoneHeapManager.h

  Log Message:
  -----------
  [TZone] Update TZone debugging code
https://bugs.webkit.org/show_bug.cgi?id=281641
rdar://138083630

Reviewed by Yijia Huang.

Added various debugging improvements to the TZone manager and allocation path for unannotated subclasses.
The changes for "verbose" compilation mode include:
 * Adding bucket counts for each size class.
 * Simplifying the data needed for statistics.
 * Using a separate verbose flag for the dump of bucket selection.
 * Moving all debug code to a .cpp file to speed up compilation when changing debug flags.

For the unannotated subclass allocation path, split the debug info into two lines so that the info isn’t truncated in the OS log.
Also fixed the spelling of the method dumpRegisteredTypes.

* Source/bmalloc/bmalloc/TZoneHeap.h:
(bmalloc::api::TZoneHeapBase::provideHeap):
* Source/bmalloc/bmalloc/TZoneHeapManager.cpp:
(bmalloc::api::dumpRegisteredTypesAtExit):
(bmalloc::api::TZoneHeapManager::init):
(bmalloc::api::TZoneHeapManager::dumpRegisteredTypes):
(bmalloc::api::TZoneHeapManager::tzoneBucketForKey):
(bmalloc::api::TZoneHeapManager::populateBucketsForSizeClass):
(bmalloc::api::TZoneHeapManager::heapRefForTZoneType):
(bmalloc::api::dumpRegisterdTypesAtExit): Deleted.
(bmalloc::api::TZoneHeapManager::dumpRegisterdTypes): Deleted.
* Source/bmalloc/bmalloc/TZoneHeapManager.h:
(bmalloc::api::TZoneHeapManager::tzoneBucketForKey): Deleted.

Canonical link: https://commits.webkit.org/285355@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications