[webkit-changes] [WebKit/WebKit] 392e37: Simplify socket ownership in ConnectionUnix.cpp

[Michael Catanzaro]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 392e377b4d137913ee367941bd47697244696ba5
      https://github.com/WebKit/WebKit/commit/392e377b4d137913ee367941bd47697244696ba5
  Author: Michael Catanzaro <mcatanzaro at redhat.com>
  Date:   2024-10-17 (Thu, 17 Oct 2024)

  Changed paths:
    M Source/WebKit/Platform/IPC/Connection.h
    M Source/WebKit/Platform/IPC/unix/ConnectionUnix.cpp

  Log Message:
  -----------
  Simplify socket ownership in ConnectionUnix.cpp
https://bugs.webkit.org/show_bug.cgi?id=281616

Reviewed by Carlos Garcia Campos.

Currently the file descriptor m_socketDescriptor exists on all platforms
but is owned only on non-GLib platforms. On GLib platforms, this file
descriptor is owned by m_socket instead. This is slightly confusing, and
entirely unnecessary: we can simply get rid of it when using GLib.

* Source/WebKit/Platform/IPC/Connection.h:
* Source/WebKit/Platform/IPC/unix/ConnectionUnix.cpp:
(IPC::Connection::socketDescriptor const):
(IPC::Connection::platformInitialize):
(IPC::Connection::platformInvalidate):
(IPC::Connection::readyReadHandler):
(IPC::Connection::platformPrepareForOpen):
(IPC::Connection::platformOpen):
(IPC::Connection::sendOutputMessage):

Canonical link: https://commits.webkit.org/285337@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications