[webkit-changes] [WebKit/WebKit] ef6644: Make UnixFileDescriptor noncopyable again

[Michael Catanzaro]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ef66440cf7fc0df67b25d65eb5c37f65acb7a467
      https://github.com/WebKit/WebKit/commit/ef66440cf7fc0df67b25d65eb5c37f65acb7a467
  Author: Michael Catanzaro <mcatanzaro at redhat.com>
  Date:   2024-10-17 (Thu, 17 Oct 2024)

  Changed paths:
    M Source/WTF/wtf/unix/UnixFileDescriptor.h
    M Source/WebCore/platform/SharedMemory.h
    M Source/WebCore/platform/unix/SharedMemoryUnix.cpp

  Log Message:
  -----------
  Make UnixFileDescriptor noncopyable again
https://bugs.webkit.org/show_bug.cgi?id=281609

Reviewed by Carlos Garcia Campos.

Make UnixFileDescriptor noncopyable again. Otherwise, it's very
difficult to use the class without accidentally duping the underlying
file descriptor.

This is a partial revert of 272365 at main. We can manually duplicate the
file descriptor in the SharedMemoryHandle copy constructor, since we
really do want a copy there.

This un-reverts 261281 at main.

* Source/WTF/wtf/unix/UnixFileDescriptor.h:
* Source/WebCore/platform/SharedMemory.h:
* Source/WebCore/platform/unix/SharedMemoryUnix.cpp:
(WebCore::SharedMemoryHandle::SharedMemoryHandle):

Canonical link: https://commits.webkit.org/285336@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications