[webkit-changes] [WebKit/WebKit] 04332c: Add checks for the case of data url in SVGURIRefer...

ziransun noreply at github.com
Thu Oct 17 01:25:14 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 04332cec0029ebb437fefa67af8e4e10b2f72ad9
      https://github.com/WebKit/WebKit/commit/04332cec0029ebb437fefa67af8e4e10b2f72ad9
  Author: Ziran Sun <zsun at igalia.com>
  Date:   2024-10-17 (Thu, 17 Oct 2024)

  Changed paths:
    M LayoutTests/TestExpectations
    M Source/WebCore/svg/SVGURIReference.cpp
    M Source/WebCore/svg/SVGUseElement.cpp

  Log Message:
  -----------
  Add checks for the case of data url in SVGURIReference.
https://bugs.webkit.org/show_bug.cgi?id=149460

Reviewed by Said Abou-Hallawa.

Add check for the case of data url in SVGURIReference.
The test still fails as it returns nullptr for the element in data url case in
SVGURIReference::targetElementFromIRIString(). We need to load the data url in
a Document to be able to get the target element for the corresponding fragement
ID.

* LayoutTests/TestExpectations:
* Source/WebCore/svg/SVGURIReference.cpp:
(WebCore::SVGURIReference::targetElementFromIRIString):
(WebCore::SVGURIReference::haveLoadedRequiredResources const):
* Source/WebCore/svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::updateExternalDocument):

Canonical link: https://commits.webkit.org/285321@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list