[webkit-changes] [WebKit/WebKit] 8b7209: [GTK] Make SystemSettingsProxy a web process suppl...

[Carlos Garcia Campos]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8b7209ba250c22f2dfb21d681ca8d706ea3a6c43
      https://github.com/WebKit/WebKit/commit/8b7209ba250c22f2dfb21d681ca8d706ea3a6c43
  Author: Carlos Garcia Campos <cgarcia at igalia.com>
  Date:   2024-10-17 (Thu, 17 Oct 2024)

  Changed paths:
    M Source/WebCore/platform/glib/SystemSettings.cpp
    M Source/WebCore/platform/glib/SystemSettings.h
    M Source/WebKit/PlatformGTK.cmake
    M Source/WebKit/PlatformWPE.cmake
    M Source/WebKit/SourcesGTK.txt
    M Source/WebKit/SourcesWPE.txt
    R Source/WebKit/UIProcess/glib/SystemSettingsManager.cpp
    R Source/WebKit/UIProcess/glib/SystemSettingsManager.h
    A Source/WebKit/UIProcess/glib/SystemSettingsManagerProxy.cpp
    A Source/WebKit/UIProcess/glib/SystemSettingsManagerProxy.h
    M Source/WebKit/UIProcess/gtk/Display.cpp
    R Source/WebKit/UIProcess/gtk/SystemSettingsManagerGtk.cpp
    A Source/WebKit/UIProcess/gtk/SystemSettingsManagerProxyGtk.cpp
    A Source/WebKit/WebProcess/glib/SystemSettingsManager.cpp
    A Source/WebKit/WebProcess/glib/SystemSettingsManager.h
    A Source/WebKit/WebProcess/glib/SystemSettingsManager.messages.in
    R Source/WebKit/WebProcess/glib/SystemSettingsProxy.cpp
    R Source/WebKit/WebProcess/glib/SystemSettingsProxy.h
    R Source/WebKit/WebProcess/glib/SystemSettingsProxy.messages.in
    M Source/WebKit/WebProcess/glib/WebProcessGLib.cpp

  Log Message:
  -----------
  [GTK] Make SystemSettingsProxy a web process supplement and rename it as SystemSettingsManager
https://bugs.webkit.org/show_bug.cgi?id=281567

Reviewed by Adrian Perez de Castro.

SystemSettingsProxy doesn't need to be a singleton, it can be a web
process supplement. The proxy is actually in the UI process, sending the
settings to all web processes, so this patch renames SystemSettingsProxy
as SystemSettingsManager and SystemSettingsManager as
SystemSettingsManagerProxy. The web process supplement now connects the
observer in the constructor and initializes the settings from web
process creation parameters later, fixing the initial settings not being
applied before.

* Source/WebCore/platform/glib/SystemSettings.cpp:
(WebCore::SystemSettings::updateSettings):
* Source/WebCore/platform/glib/SystemSettings.h:
* Source/WebKit/PlatformGTK.cmake:
* Source/WebKit/PlatformWPE.cmake:
* Source/WebKit/SourcesGTK.txt:
* Source/WebKit/SourcesWPE.txt:
* Source/WebKit/UIProcess/glib/SystemSettingsManagerProxy.cpp: Renamed from Source/WebKit/UIProcess/glib/SystemSettingsManager.cpp.
(WebKit::SystemSettingsManagerProxy::themeName const):
(WebKit::SystemSettingsManagerProxy::darkMode const):
(WebKit::SystemSettingsManagerProxy::fontName const):
(WebKit::SystemSettingsManagerProxy::xftAntialias const):
(WebKit::SystemSettingsManagerProxy::xftHinting const):
(WebKit::SystemSettingsManagerProxy::xftHintStyle const):
(WebKit::SystemSettingsManagerProxy::xftRGBA const):
(WebKit::SystemSettingsManagerProxy::xftDPI const):
(WebKit::SystemSettingsManagerProxy::cursorBlink const):
(WebKit::SystemSettingsManagerProxy::cursorBlinkTime const):
(WebKit::SystemSettingsManagerProxy::primaryButtonWarpsSlider const):
(WebKit::SystemSettingsManagerProxy::overlayScrolling const):
(WebKit::SystemSettingsManagerProxy::enableAnimations const):
(WebKit::SystemSettingsManagerProxy::initialize):
(WebKit::SystemSettingsManagerProxy::settingsDidChange):
* Source/WebKit/UIProcess/glib/SystemSettingsManagerProxy.h: Renamed from Source/WebKit/UIProcess/glib/SystemSettingsManager.h.
* Source/WebKit/UIProcess/gtk/Display.cpp:
(WebKit::Display::Display):
* Source/WebKit/UIProcess/gtk/SystemSettingsManagerProxyGtk.cpp: Renamed from Source/WebKit/UIProcess/gtk/SystemSettingsManagerGtk.cpp.
(WebKit::SystemSettingsManagerProxy::themeName const):
(WebKit::SystemSettingsManagerProxy::darkMode const):
(WebKit::SystemSettingsManagerProxy::fontName const):
(WebKit::SystemSettingsManagerProxy::xftAntialias const):
(WebKit::SystemSettingsManagerProxy::xftHinting const):
(WebKit::SystemSettingsManagerProxy::xftHintStyle const):
(WebKit::SystemSettingsManagerProxy::xftRGBA const):
(WebKit::SystemSettingsManagerProxy::xftDPI const):
(WebKit::SystemSettingsManagerProxy::cursorBlink const):
(WebKit::SystemSettingsManagerProxy::cursorBlinkTime const):
(WebKit::SystemSettingsManagerProxy::primaryButtonWarpsSlider const):
(WebKit::SystemSettingsManagerProxy::overlayScrolling const):
(WebKit::SystemSettingsManagerProxy::enableAnimations const):
(WebKit::SystemSettingsManagerProxy::SystemSettingsManagerProxy):
* Source/WebKit/WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeProcess):
* Source/WebKit/WebProcess/glib/SystemSettingsManager.cpp: Added.
(WebKit::SystemSettingsManager::SystemSettingsManager):
(WebKit::SystemSettingsManager::~SystemSettingsManager):
(WebKit::SystemSettingsManager::supplementName):
(WebKit::SystemSettingsManager::initialize):
(WebKit::SystemSettingsManager::didChange):
* Source/WebKit/WebProcess/glib/SystemSettingsManager.h: Renamed from Source/WebKit/WebProcess/glib/SystemSettingsProxy.h.
* Source/WebKit/WebProcess/glib/SystemSettingsManager.messages.in: Renamed from Source/WebKit/WebProcess/glib/SystemSettingsProxy.messages.in.
* Source/WebKit/WebProcess/glib/SystemSettingsProxy.cpp: Removed.
* Source/WebKit/WebProcess/glib/WebProcessGLib.cpp:
(WebKit::WebProcess::platformInitializeProcess):
(WebKit::WebProcess::platformInitializeWebProcess):
(WebKit::WebProcess::platformTerminate):

Canonical link: https://commits.webkit.org/285320@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications