[webkit-changes] [WebKit/WebKit] 71c954: [TZone] Add TZone annotation macros for structs

Michael Saboff noreply at github.com
Wed Oct 16 10:56:59 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 71c9542da1c301de4ab7c96c541a8cbc97d6c432
      https://github.com/WebKit/WebKit/commit/71c9542da1c301de4ab7c96c541a8cbc97d6c432
  Author: Michael Saboff <msaboff at apple.com>
  Date:   2024-10-16 (Wed, 16 Oct 2024)

  Changed paths:
    M Source/JavaScriptCore/bytecode/LazyValueProfile.h
    M Source/JavaScriptCore/bytecode/UnlinkedFunctionExecutable.cpp
    M Source/JavaScriptCore/bytecode/UnlinkedFunctionExecutable.h
    M Source/JavaScriptCore/dfg/DFGOSRExit.cpp
    M Source/JavaScriptCore/dfg/DFGOSRExit.h
    M Source/JavaScriptCore/inspector/remote/socket/RemoteInspectorSocketEndpoint.cpp
    M Source/JavaScriptCore/inspector/remote/socket/RemoteInspectorSocketEndpoint.h
    M Source/JavaScriptCore/jit/JITMathIC.h
    M Source/JavaScriptCore/jit/JITTZoneImpls.cpp
    M Source/JavaScriptCore/parser/VariableEnvironment.cpp
    M Source/JavaScriptCore/parser/VariableEnvironment.h
    M Source/WTF/wtf/TZoneMalloc.h
    M Source/WTF/wtf/TZoneMallocInlines.h
    M Source/WebCore/Modules/airplay/WebMediaSessionManager.cpp
    M Source/WebCore/PAL/pal/crypto/commoncrypto/CryptoDigestCommonCrypto.cpp
    M Source/WebCore/rendering/BidiRun.cpp
    M Source/WebCore/rendering/BidiRun.h
    M Source/WebKit/Shared/API/Cocoa/RemoteObjectInvocation.h
    M Source/bmalloc/bmalloc/TZoneHeap.h
    M Source/bmalloc/bmalloc/TZoneHeapInlines.h

  Log Message:
  -----------
  [TZone] Add TZone annotation macros for structs
https://bugs.webkit.org/show_bug.cgi?id=281514
rdar://137985417

Reviewed by Yijia Huang.

Split the existing MAKE_BTZONE_MALLOCED macro into MAKE_BTZONE_MALLOCED_COMMON, that doesn't have access specifiers,
and MAKE_BTZONE_MALLOCED, which invokes MAKE_BTZONE_MALLOCED_COMMON with a public specifier before and a
private specifier after.  Created a new MAKE_STRUCT_BTZONE_MALLOCED that just invokes MAKE_BTZONE_MALLOCED_COMMON.
Both the class and struct macros include a dummy using statement to allow them to be followed by a semicolon.
Made similar changes to MAKE_BTZONE_MALLOCED_INLINE.

Added WTF_MAKE_STRUCT_TZONE_ALLOCATED and WTF_MAKE_STRUCT_TZONE_ALLOCATED_INLINE which call the new MAKE_BTZONE_* macros.

Used both of the new WTF_MAKE_STRUCT_TZONE_ALLOCATED* macros in a few files, replacing WTF_MAKE_STRUCT_FAST_ALLOCATED in
some places and added WTF_MAKE_STRUCT_TZONE_ALLOCATED in a few places where there wasn't a WTF_MAKE_STRUCT_FAST_ALLOCATED.

Note that the nested struct RemoteObjectInvocation::ReplyInfo was previously annotated using the "class" annotation macro.
This worked because RemoteObjectInvocation::ReplyInfo had an existing public: specifier.  For consistency,
changed RemoteObjectInvocation::ReplyInfo to use WTF_MAKE_STRUCT_TZONE_ALLOCATED instead and removed the public: specifier.

* Source/JavaScriptCore/bytecode/LazyValueProfile.h:
* Source/JavaScriptCore/bytecode/UnlinkedFunctionExecutable.cpp:
* Source/JavaScriptCore/bytecode/UnlinkedFunctionExecutable.h:
* Source/JavaScriptCore/dfg/DFGOSRExit.cpp:
* Source/JavaScriptCore/dfg/DFGOSRExit.h:
* Source/JavaScriptCore/inspector/remote/socket/RemoteInspectorSocketEndpoint.cpp:
* Source/JavaScriptCore/inspector/remote/socket/RemoteInspectorSocketEndpoint.h:
* Source/JavaScriptCore/jit/JITMathIC.h:
* Source/JavaScriptCore/jit/JITTZoneImpls.cpp:
* Source/JavaScriptCore/parser/VariableEnvironment.cpp:
* Source/JavaScriptCore/parser/VariableEnvironment.h:
* Source/WTF/wtf/TZoneMalloc.h:
* Source/WTF/wtf/TZoneMallocInlines.h:
* Source/WebCore/Modules/airplay/WebMediaSessionManager.cpp:
* Source/WebCore/PAL/pal/crypto/commoncrypto/CryptoDigestCommonCrypto.cpp:
* Source/WebCore/rendering/BidiRun.cpp:
* Source/WebCore/rendering/BidiRun.h:
* Source/WebKit/Shared/API/Cocoa/RemoteObjectInvocation.h:
* Source/bmalloc/bmalloc/TZoneHeap.h:
* Source/bmalloc/bmalloc/TZoneHeapInlines.h:

Canonical link: https://commits.webkit.org/285280@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list