[webkit-changes] [WebKit/WebKit] 9c0c04: [TZone] Add annotations for X86_64 Darwin builds

Michael Saboff noreply at github.com
Wed Oct 16 10:54:35 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9c0c04ed0b589af2bcf269574e9c221e15354630
      https://github.com/WebKit/WebKit/commit/9c0c04ed0b589af2bcf269574e9c221e15354630
  Author: Michael Saboff <msaboff at apple.com>
  Date:   2024-10-16 (Wed, 16 Oct 2024)

  Changed paths:
    M Source/JavaScriptCore/assembler/MacroAssembler.cpp
    M Source/JavaScriptCore/assembler/MacroAssembler.h
    M Source/JavaScriptCore/assembler/MacroAssemblerARM64E.h
    M Source/JavaScriptCore/assembler/MacroAssemblerX86_64.h
    M Source/JavaScriptCore/jit/ExecutableAllocator.cpp
    M Source/WTF/wtf/PlatformUse.h
    M Source/bmalloc/bmalloc/BPlatform.h
    M Source/bmalloc/bmalloc/Map.h
    M Source/bmalloc/bmalloc/TZoneLog.cpp

  Log Message:
  -----------
  [TZone] Add annotations for X86_64 Darwin builds
https://bugs.webkit.org/show_bug.cgi?id=281505
rdar://137973227

Reviewed by Yijia Huang.

Added TZone annotations to X86_64 MacroAssembler.  Also filled out annotations for the MacroAssembler template class
tree including MacroAssemblerARM64E.  Needed to make the annotation for FixedVMPoolExecutableAllocator::Islands
conditional on ENABLE(JUMP_ISLANDS).  ASAN build found that bmalloc::Map had uninitialized members in the TZone paths,
so added a bmalloc::Map constructor to initialize its fields.  The X86 public SDK also found that the Printf
attributes for TZoneLog::osLogWithLineBuffer() needed fixing.

* Source/JavaScriptCore/assembler/MacroAssembler.cpp:
* Source/JavaScriptCore/assembler/MacroAssembler.h:
* Source/JavaScriptCore/assembler/MacroAssemblerARM64E.h:
* Source/JavaScriptCore/assembler/MacroAssemblerX86_64.h:
* Source/JavaScriptCore/jit/ExecutableAllocator.cpp:
* Source/WTF/wtf/PlatformUse.h:
* Source/bmalloc/bmalloc/BPlatform.h:
* Source/bmalloc/bmalloc/Map.h:
(bmalloc::allowDeleting>::Map):
* Source/bmalloc/bmalloc/TZoneLog.cpp:

Canonical link: https://commits.webkit.org/285279@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list