[webkit-changes] [WebKit/WebKit] cc6a87: [Cocoa] Preserve provenance metadata for adaptive ...

[Aditya Keerthi]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cc6a876ba68c9210c7caf53695e1ebeb718f23df
      https://github.com/WebKit/WebKit/commit/cc6a876ba68c9210c7caf53695e1ebeb718f23df
  Author: Aditya Keerthi <akeerthi at apple.com>
  Date:   2024-10-15 (Tue, 15 Oct 2024)

  Changed paths:
    M Source/WTF/wtf/PlatformHave.h
    M Source/WebCore/editing/cocoa/AttributedString.mm
    M Source/WebCore/editing/cocoa/TextAttachmentForSerialization.h
    M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in
    M Tools/TestWebKitAPI/Configurations/TestWebKitAPIBase.xcconfig
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/AdaptiveImageGlyph.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/adaptive-image-glyph.heic

  Log Message:
  -----------
  [Cocoa] Preserve provenance metadata for adaptive image glyphs
https://bugs.webkit.org/show_bug.cgi?id=281286
rdar://130973927

Reviewed by Abrar Rahman Protyasha.

Preserve credit and digital source type information for adaptive image glyphs
when they are decomposed and recomposed across process boundaries.

* Source/WTF/wtf/PlatformHave.h:
* Source/WebCore/editing/cocoa/AttributedString.mm:
(WebCore::toMultiRepresentationHEICAttachmentData):
(WebCore::toWebMultiRepresentationHEICAttachment):

Deprecation guards in the old codepath are preserved since the methods were
incorrectly deprecated in an OS version that does not have the replacement.

* Source/WebCore/editing/cocoa/TextAttachmentForSerialization.h:
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:
* Tools/TestWebKitAPI/Configurations/TestWebKitAPIBase.xcconfig:

Link ImageIO on visionOS to support use of IPTC fields in the updated test.

* Tools/TestWebKitAPI/Tests/WebKitCocoa/AdaptiveImageGlyph.mm:
(TestWebKitAPI::TEST(AdaptiveImageGlyph, InsertAndRemoveWKAttachments)):
(TestWebKitAPI::TEST(AdaptiveImageGlyph, InsertWKAttachmentsOnPaste)):
(TestWebKitAPI::TEST(AdaptiveImageGlyph, InsertWKAttachmentsCopyFromWebViewPasteToWebView)):
(TestWebKitAPI::TEST(AdaptiveImageGlyph, InsertWKAttachmentsMovingParagraphs)):
(TestWebKitAPI::TEST(AdaptiveImageGlyph, ContentsAsAttributedString)):

Skip asserting things about the provenance metadata until a CoreText fix
(rdar://137757841) to ensure the metadata can be read off of an adaptive image
glyph created from data is available in the build.

* Tools/TestWebKitAPI/Tests/WebKitCocoa/adaptive-image-glyph.heic:

Update test resource to include provenance metadata.

Canonical link: https://commits.webkit.org/285202@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications