[webkit-changes] [WebKit/WebKit] 5d4d97: [JSC] Apply string search for substring match glob...

[Yijia Huang]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5d4d979260eea6c0c2d55beef34a3ade47905f01
      https://github.com/WebKit/WebKit/commit/5d4d979260eea6c0c2d55beef34a3ade47905f01
  Author: Yijia Huang <yijia_huang at apple.com>
  Date:   2024-10-15 (Tue, 15 Oct 2024)

  Changed paths:
    A JSTests/microbenchmarks/global-atom-substring-match-multi-chars.js
    A JSTests/microbenchmarks/global-atom-substring-match-one-char.js
    R JSTests/microbenchmarks/global-atom-substring-match.js
    M Source/JavaScriptCore/dfg/DFGOperations.cpp
    M Source/JavaScriptCore/runtime/RegExpObject.cpp
    M Source/JavaScriptCore/runtime/RegExpSubstringGlobalAtomCache.cpp

  Log Message:
  -----------
  [JSC] Apply string search for substring match global, atom, and one char pattern
https://bugs.webkit.org/show_bug.cgi?id=281440
rdar://137891651

Reviewed by Yusuke Suzuki.

RegExp match is slow. This patch applies string search for
substring match with global, atom, and one char pattern.

                                                   before                    after

global-atom-substring-match-multi-chars        1.6233+-0.0061     ?      1.6337+-0.0057        ?
global-atom-substring-match-one-char           4.8063+-0.0086     ^      1.9914+-0.0066        ^ definitely 2.4135x faster

* JSTests/microbenchmarks/global-atom-substring-match-multi-chars.js: Copied from JSTests/microbenchmarks/global-atom-substring-match.js.
(test):
* JSTests/microbenchmarks/global-atom-substring-match-one-char.js: Renamed from JSTests/microbenchmarks/global-atom-substring-match.js.
(test):
* Source/JavaScriptCore/dfg/DFGOperations.cpp:
(JSC::DFG::JSC_DEFINE_JIT_OPERATION):
* Source/JavaScriptCore/runtime/RegExpObject.cpp:
(JSC::RegExpObject::matchGlobal):
* Source/JavaScriptCore/runtime/RegExpSubstringGlobalAtomCache.cpp:
(JSC::RegExpSubstringGlobalAtomCache::collectMatches):

Canonical link: https://commits.webkit.org/285201@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications