[webkit-changes] [WebKit/WebKit] 8faeb1: [WebGPU] Out of memory should trigger a device lost

mwyrzykowski noreply at github.com
Mon Oct 14 22:38:13 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8faeb1bdbecb178cab09a31ac42e7a34829d3c5f
      https://github.com/WebKit/WebKit/commit/8faeb1bdbecb178cab09a31ac42e7a34829d3c5f
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2024-10-14 (Mon, 14 Oct 2024)

  Changed paths:
    A LayoutTests/fast/webgpu/nocrash/fuzz-280929-expected.txt
    A LayoutTests/fast/webgpu/nocrash/fuzz-280929.html
    M Source/WebCore/Modules/WebGPU/Implementation/WebGPUImpl.cpp
    M Source/WebCore/Modules/WebGPU/Implementation/WebGPUImpl.h
    M Source/WebCore/Modules/WebGPU/InternalAPI/WebGPU.h
    M Source/WebGPU/WebGPU/Adapter.h
    M Source/WebGPU/WebGPU/Adapter.mm
    M Source/WebGPU/WebGPU/Instance.h
    M Source/WebGPU/WebGPU/Instance.mm
    M Source/WebGPU/WebGPU/WebGPUExt.h
    M Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp
    M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteGPU.cpp
    M Source/WebKit/GPUProcess/graphics/WebGPU/RemoteGPU.h
    M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteGPUProxy.cpp
    M Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteGPUProxy.h

  Log Message:
  -----------
  [WebGPU] Out of memory should trigger a device lost
https://bugs.webkit.org/show_bug.cgi?id=280929
rdar://136221917

Reviewed by Tadeu Zagallo.

Trigger device lost in low memory scenarios to avoid excessive allocations
on iOS from causing process crashes.

* LayoutTests/fast/webgpu/nocrash/fuzz-280929-expected.txt: Added.
* LayoutTests/fast/webgpu/nocrash/fuzz-280929.html: Added.
Add regression test.

* Source/WebCore/Modules/WebGPU/Implementation/WebGPUImpl.cpp:
(WebCore::WebGPU::GPUImpl::loseTheDevice):
* Source/WebCore/Modules/WebGPU/Implementation/WebGPUImpl.h:
* Source/WebCore/Modules/WebGPU/InternalAPI/WebGPU.h:
* Source/WebGPU/WebGPU/Adapter.h:
(WebGPU::Adapter::makeInvalid): Deleted.
* Source/WebGPU/WebGPU/Adapter.mm:
(WebGPU::Adapter::requestDevice):
(WebGPU::Adapter::makeInvalid):
* Source/WebGPU/WebGPU/Instance.h:
* Source/WebGPU/WebGPU/Instance.mm:
(WebGPU::Instance::loseAllDevices):
(WebGPU::Instance::requestAdapter):
(wgpuInstanceLoseAllDevices):
* Source/WebGPU/WebGPU/WebGPUExt.h:
* Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp:
(WebKit::GPUConnectionToWebProcess::lowMemoryHandler):
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteGPU.cpp:
(WebKit::RemoteGPU::lowMemoryHandler):
* Source/WebKit/GPUProcess/graphics/WebGPU/RemoteGPU.h:
* Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteGPUProxy.cpp:
(WebKit::RemoteGPUProxy::loseTheDevice):
* Source/WebKit/WebProcess/GPU/graphics/WebGPU/RemoteGPUProxy.h:

Canonical link: https://commits.webkit.org/285178@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list