[webkit-changes] [WebKit/WebKit] b30afe: Regression(285161 at main) Crash in debug under WebSQ...

Chris Dumez noreply at github.com
Mon Oct 14 22:21:48 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b30afe7d03bc68b7a2928e469e5d6a64352d2515
      https://github.com/WebKit/WebKit/commit/b30afe7d03bc68b7a2928e469e5d6a64352d2515
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2024-10-14 (Mon, 14 Oct 2024)

  Changed paths:
    M Source/WebKit/Shared/WebSQLiteDatabaseTracker.cpp

  Log Message:
  -----------
  Regression(285161 at main) Crash in debug under WebSQLiteDatabaseTracker::setIsHoldingLockedFiles(bool)
https://bugs.webkit.org/show_bug.cgi?id=281468
rdar://137923861

Reviewed by Ben Nham.

Make sure we call setIsHoldingLockedFiles() on the main run loop since it calls
the `m_isHoldingLockedFilesHandler` lambda which ends up ref'ing the NetworkProcess
object. It is only safe to ref / deref (and use) the NetworkProcess object on the
main run loop.

* Source/WebKit/Shared/WebSQLiteDatabaseTracker.cpp:
(WebKit::WebSQLiteDatabaseTracker::willBeginFirstTransaction):

Canonical link: https://commits.webkit.org/285177@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list