[webkit-changes] [WebKit/WebKit] 6b4b64: Port WebExtension Permissions and Match Patterns t...

[Jamie Murphy]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6b4b64e0f2638de129ff167b5df8dfd88a9a9889
      https://github.com/WebKit/WebKit/commit/6b4b64e0f2638de129ff167b5df8dfd88a9a9889
  Author: Jamie <hello at itsjamie.dev>
  Date:   2024-10-12 (Sat, 12 Oct 2024)

  Changed paths:
    A Source/WebKit/Shared/Extensions/WebExtensionPermission.cpp
    A Source/WebKit/Shared/Extensions/WebExtensionPermission.h
    M Source/WebKit/Sources.txt
    M Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCocoa.mm
    M Source/WebKit/UIProcess/Extensions/WebExtension.cpp
    M Source/WebKit/UIProcess/Extensions/WebExtension.h
    M Source/WebKit/WebKit.xcodeproj/project.pbxproj

  Log Message:
  -----------
  Port WebExtension Permissions and Match Patterns to C++
https://webkit.org/b/281388

Reviewed by Timothy Hatcher.

This creates a new WebExtensionPermission class in Shared/Extensions to store the permission constants, instead of relying on the Cocoa API. This also ports the code in the manifest parser that deals with permissions and externally connectable match patterns.

* Source/WebKit/Shared/Extensions/WebExtensionPermission.cpp: Added.
(WebKit::WebExtensionPermission::activeTab):
(WebKit::WebExtensionPermission::alarms):
(WebKit::WebExtensionPermission::clipboardWrite):
(WebKit::WebExtensionPermission::contextMenus):
(WebKit::WebExtensionPermission::cookies):
(WebKit::WebExtensionPermission::declarativeNetRequest):
(WebKit::WebExtensionPermission::declarativeNetRequestFeedback):
(WebKit::WebExtensionPermission::declarativeNetRequestWithHostAccess):
(WebKit::WebExtensionPermission::menus):
(WebKit::WebExtensionPermission::nativeMessaging):
(WebKit::WebExtensionPermission::notifications):
(WebKit::WebExtensionPermission::scripting):
(WebKit::WebExtensionPermission::sidePanel):
(WebKit::WebExtensionPermission::storage):
(WebKit::WebExtensionPermission::tabs):
(WebKit::WebExtensionPermission::unlimitedStorage):
(WebKit::WebExtensionPermission::webNavigation):
(WebKit::WebExtensionPermission::webRequest):
* Source/WebKit/Shared/Extensions/WebExtensionPermission.h: Added.
* Source/WebKit/Sources.txt:
* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionCocoa.mm:
(WebKit::WebExtension::populateDeclarativeNetRequestPropertiesIfNeeded):
(WebKit::WebExtension::populateExternallyConnectableIfNeeded): Deleted.
(WebKit::WebExtension::hasSidePanel): Deleted.
(WebKit::WebExtension::supportedPermissions): Deleted.
(WebKit::WebExtension::requestedPermissions): Deleted.
(WebKit::WebExtension::optionalPermissions): Deleted.
(WebKit::WebExtension::requestedPermissionMatchPatterns): Deleted.
(WebKit::WebExtension::optionalPermissionMatchPatterns): Deleted.
(WebKit::WebExtension::externallyConnectableMatchPatterns): Deleted.
(WebKit::WebExtension::allRequestedMatchPatterns): Deleted.
(WebKit::WebExtension::populatePermissionsPropertiesIfNeeded): Deleted.
* Source/WebKit/UIProcess/Extensions/WebExtension.cpp:
(WebKit::WebExtension::hasSidePanel):
(WebKit::WebExtension::supportedPermissions):
(WebKit::WebExtension::requestedPermissions):
(WebKit::WebExtension::optionalPermissions):
(WebKit::WebExtension::requestedPermissionMatchPatterns):
(WebKit::WebExtension::optionalPermissionMatchPatterns):
(WebKit::WebExtension::externallyConnectableMatchPatterns):
(WebKit::WebExtension::allRequestedMatchPatterns):
(WebKit::WebExtension::populateExternallyConnectableIfNeeded):
(WebKit::WebExtension::populatePermissionsPropertiesIfNeeded):
* Source/WebKit/UIProcess/Extensions/WebExtension.h:
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:

Canonical link: https://commits.webkit.org/285084@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications