[webkit-changes] [WebKit/WebKit] 353791: Simplify data flow of WebCore::createWindow

[Alex Christensen]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 353791d0219c505f88ae7c155c45e11395eac7c1
      https://github.com/WebKit/WebKit/commit/353791d0219c505f88ae7c155c45e11395eac7c1
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2024-10-12 (Sat, 12 Oct 2024)

  Changed paths:
    M Source/WebCore/inspector/InspectorFrontendClientLocal.cpp
    M Source/WebCore/loader/FrameLoader.cpp
    M Source/WebCore/loader/FrameLoader.h
    M Source/WebCore/page/LocalDOMWindow.cpp

  Log Message:
  -----------
  Simplify data flow of WebCore::createWindow
https://bugs.webkit.org/show_bug.cgi?id=281383
rdar://137806111

Reviewed by Charlie Wolfe.

WebCore::createWindow has 2 callers, InspectorFrontendClientLocal that doesn't
pass in any window features and doesn't care about the resulting window features,
and LocalDOMWindow which passes in the window features from JS and then looks at
the features that WebCore::createWindow has possibly modified.  This moves the
modification code to LocalDOMWindow to make the side effects of WebCore::createWindow
more clear.

* Source/WebCore/inspector/InspectorFrontendClientLocal.cpp:
(WebCore::InspectorFrontendClientLocal::openURLExternally):
* Source/WebCore/loader/FrameLoader.cpp:
(WebCore::createWindow):
* Source/WebCore/loader/FrameLoader.h:
* Source/WebCore/page/LocalDOMWindow.cpp:
(WebCore::LocalDOMWindow::createWindow):

Canonical link: https://commits.webkit.org/285083@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications