[webkit-changes] [WebKit/WebKit] e15267: REGRESSION(284461 at main?) [ iPad ] 4x TestWebKitAPI...

[Wenson Hsieh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e1526704268bbe8bc3050402e9a1f9d800167e81
      https://github.com/WebKit/WebKit/commit/e1526704268bbe8bc3050402e9a1f9d800167e81
  Author: Wenson Hsieh <wenson_hsieh at apple.com>
  Date:   2024-10-11 (Fri, 11 Oct 2024)

  Changed paths:
    M Source/WebKit/UIProcess/ios/WKTextInteractionWrapper.mm

  Log Message:
  -----------
  REGRESSION(284461 at main?) [ iPad ] 4x TestWebKitAPI.DocumentEditingContext.CharacterRectConsistency* (api-tests) are constant timeouts
https://bugs.webkit.org/show_bug.cgi?id=281332
rdar://137769684

Reviewed by Abrar Rahman Protyasha.

These API tests began to fail on iPadOS after the changes in 284461 at main; this is because in the
case where `USE(BROWSERENGINEKIT)` is enabled but the runtime flag for async text input on iPad is
*disabled*, the newly introduced `-[WKTextInteractionWrapper textSelectionDisplayInteraction]`
helper method returns `nil`. This in turn causes `-activateSelection` and `-deactivateSelection` to
become no-ops.

Fix this by preserving the old codepath in the case where `USE(BROWSERENGINEKIT)` is enabled but
`_asyncTextInteraction` is `nil`, by falling back to iterating over the content view's interactions
until we find an instance of `UITextSelectionDisplayInteraction`.

* Source/WebKit/UIProcess/ios/WKTextInteractionWrapper.mm:
(-[WKTextInteractionWrapper textSelectionDisplayInteraction]):

Canonical link: https://commits.webkit.org/285060@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications