[webkit-changes] [WebKit/WebKit] ab1d74: Move remaining logic after window creation to a mo...

Alex Christensen noreply at github.com
Fri Oct 11 22:17:11 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: ab1d7484b48586a3718a18086e9dbe313b31baf0
      https://github.com/WebKit/WebKit/commit/ab1d7484b48586a3718a18086e9dbe313b31baf0
  Author: Alex Christensen <achristensen at apple.com>
  Date:   2024-10-11 (Fri, 11 Oct 2024)

  Changed paths:
    M Source/WebCore/loader/EmptyClients.h
    M Source/WebCore/loader/FrameLoader.cpp
    M Source/WebCore/page/Chrome.cpp
    M Source/WebCore/page/Chrome.h
    M Source/WebCore/page/ChromeClient.h
    M Source/WebCore/page/ContextMenuController.cpp
    M Source/WebKit/Shared/NavigationActionData.h
    M Source/WebKit/Shared/NavigationActionData.serialization.in
    M Source/WebKit/Shared/WebPageCreationParameters.h
    M Source/WebKit/Shared/WebPageCreationParameters.serialization.in
    M Source/WebKit/UIProcess/API/APIPageConfiguration.cpp
    M Source/WebKit/UIProcess/API/APIPageConfiguration.h
    M Source/WebKit/UIProcess/WebPageProxy.cpp
    M Source/WebKit/UIProcess/WebPageProxy.h
    M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp
    M Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h
    M Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp
    M Source/WebKit/WebProcess/WebCoreSupport/WebLocalFrameLoaderClient.cpp
    M Source/WebKit/WebProcess/WebPage/WebPage.cpp
    M Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.h
    M Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.mm

  Log Message:
  -----------
  Move remaining logic after window creation to a more site-isolation friendly location
https://bugs.webkit.org/show_bug.cgi?id=281278
rdar://137727133

Reviewed by Charlie Wolfe.

With site isolation, the opened page might be in a different process than the opener,
so we need to pass parameters to the UI process to set the frame name in whatever process
the page is created in instead of keeping the parameters in memory and modifying the
created page after creation, which can only be done in the same process.

* Source/WebCore/loader/FrameLoader.cpp:
(WebCore::createWindow):

Canonical link: https://commits.webkit.org/285059@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list