[webkit-changes] [WebKit/WebKit] 30e65e: [IFC] Line layout may get on the same vertical pos...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 30e65eafbb609fa1a12ecc6a4ef36f54c6fb4406
      https://github.com/WebKit/WebKit/commit/30e65eafbb609fa1a12ecc6a4ef36f54c6fb4406
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-10-09 (Wed, 09 Oct 2024)

  Changed paths:
    A LayoutTests/fast/inline/very-tall-floats-with-saturated-layout-unit-value-expected.txt
    A LayoutTests/fast/inline/very-tall-floats-with-saturated-layout-unit-value.html
    M Source/WebCore/layout/formattingContexts/inline/InlineFormattingUtils.cpp

  Log Message:
  -----------
  [IFC] Line layout may get on the same vertical position with extremely tall floats
https://bugs.webkit.org/show_bug.cgi?id=281088
<rdar://137178835>

Reviewed by Antti Koivisto.

When computing the vertical position candidate for the next line by trying to avoid floats,
with extremely tall floats we could end up in value range where LayoutUnit -> float conversion
ends up putting us back to the same y. Let's use nextafter to ensure we never get stuck on the same line.

* LayoutTests/fast/inline/very-tall-floats-with-saturated-layout-unit-value-expected.txt: Added.
* LayoutTests/fast/inline/very-tall-floats-with-saturated-layout-unit-value.html: Added.
* Source/WebCore/layout/formattingContexts/inline/InlineFormattingUtils.cpp:
(WebCore::Layout::InlineFormattingUtils::logicalTopForNextLine const):

Canonical link: https://commits.webkit.org/284888@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications