[webkit-changes] [WebKit/WebKit] 2cb4e8: [IFC] ruby's rt is not eligible for TextOnlySimple...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2cb4e8acbc795e26115249aba6fec987fbc3ea70
      https://github.com/WebKit/WebKit/commit/2cb4e8acbc795e26115249aba6fec987fbc3ea70
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-10-09 (Wed, 09 Oct 2024)

  Changed paths:
    A LayoutTests/fast/ruby/crash-when-rt-has-block-first-letter-expected.txt
    A LayoutTests/fast/ruby/crash-when-rt-has-block-first-letter.html
    M Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp

  Log Message:
  -----------
  [IFC] ruby's rt is not eligible for TextOnlySimpleLineBuilder
https://bugs.webkit.org/show_bug.cgi?id=281091
<rdar://137177612>

Reviewed by Antti Koivisto.

Let's (re)set m_isTextAndForcedLineBreakOnlyContent in InlineItemsBuilder::handleInlineBoxEnd in a less error-prone way.

* LayoutTests/fast/ruby/crash-when-rt-has-block-first-letter-expected.txt: Added.
* LayoutTests/fast/ruby/crash-when-rt-has-block-first-letter.html: Added.
* Source/WebCore/layout/formattingContexts/inline/InlineItemsBuilder.cpp:
(WebCore::Layout::InlineItemsBuilder::handleInlineLevelBox): if (layoutBox.isRubyAnnotationBox()) branch missed to set the m_isTextAndForcedLineBreakOnlyContent flag.

Canonical link: https://commits.webkit.org/284887@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications