[webkit-changes] [WebKit/WebKit] e29796: [Cleanup] Detach ConstraintsForFlexContent from Co...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e297964612354597c34cb17f06c66087a1b018e8
      https://github.com/WebKit/WebKit/commit/e297964612354597c34cb17f06c66087a1b018e8
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-10-08 (Tue, 08 Oct 2024)

  Changed paths:
    M Source/WebCore/layout/formattingContexts/flex/FlexFormattingConstraints.h
    M Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp
    M Source/WebCore/layout/integration/flex/LayoutIntegrationFlexLayout.cpp

  Log Message:
  -----------
  [Cleanup] Detach ConstraintsForFlexContent from ConstraintsForInFlowContent
https://bugs.webkit.org/show_bug.cgi?id=281020

Reviewed by Antti Koivisto.

ConstraintsForInFlowContent is heavily single axis based which makes class methods like
logicalLeft/right slightly confusing when flex main axis is not parallel with inline axis.

* Source/WebCore/layout/formattingContexts/flex/FlexFormattingConstraints.h:
(WebCore::Layout::ConstraintsForFlexContent::ConstraintsForFlexContent):
* Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:
(WebCore::Layout::FlexFormattingContext::layout):
(WebCore::Layout::FlexFormattingContext::convertFlexItemsToLogicalSpace):
(WebCore::Layout::FlexFormattingContext::setFlexItemsGeometry):
* Source/WebCore/layout/integration/flex/LayoutIntegrationFlexLayout.cpp:
(WebCore::LayoutIntegration::FlexLayout::layout):

Canonical link: https://commits.webkit.org/284822@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications