[webkit-changes] [WebKit/WebKit] cd2c57: [Cleanup] ConstraintsForFlexContent should have bo...

Alan Baradlay noreply at github.com
Tue Oct 8 04:31:20 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cd2c5756b2e1640d71ec21e4b5007f5770994ad7
      https://github.com/WebKit/WebKit/commit/cd2c5756b2e1640d71ec21e4b5007f5770994ad7
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-10-08 (Tue, 08 Oct 2024)

  Changed paths:
    M Source/WebCore/layout/formattingContexts/flex/FlexFormattingConstraints.h
    M Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp
    M Source/WebCore/layout/formattingContexts/flex/FlexLayout.cpp
    M Source/WebCore/layout/formattingContexts/flex/FlexLayout.h
    M Source/WebCore/layout/integration/flex/LayoutIntegrationFlexLayout.cpp

  Log Message:
  -----------
  [Cleanup] ConstraintsForFlexContent should have both main and cross axis information
https://bugs.webkit.org/show_bug.cgi?id=281008

Reviewed by Antti Koivisto.

This is in preparation for computing min/max height/width values for flex layout.

* Source/WebCore/layout/formattingContexts/flex/FlexFormattingConstraints.h:
(WebCore::Layout::ConstraintsForFlexContent::mainAxis const):
(WebCore::Layout::ConstraintsForFlexContent::crossAxis const):
(WebCore::Layout::ConstraintsForFlexContent::ConstraintsForFlexContent):
(WebCore::Layout::ConstraintsForFlexContent::availableVerticalSpace const): Deleted.
(WebCore::Layout::ConstraintsForFlexContent::minimumVerticalSpace const): Deleted.
* Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp:
(WebCore::Layout::FlexFormattingContext::layout):
(WebCore::Layout::FlexFormattingContext::convertFlexItemsToLogicalSpace):
(WebCore::Layout::FlexFormattingContext::setFlexItemsGeometry):
* Source/WebCore/layout/formattingContexts/flex/FlexLayout.cpp:
(WebCore::Layout::FlexLayout::layout):
(WebCore::Layout::FlexLayout::flexContainerInnerMainSize const):
(WebCore::Layout::FlexLayout::crossSizeForFlexLines const):
* Source/WebCore/layout/formattingContexts/flex/FlexLayout.h:
(): Deleted.
* Source/WebCore/layout/integration/flex/LayoutIntegrationFlexLayout.cpp:
(WebCore::LayoutIntegration::FlexLayout::layout):

Canonical link: https://commits.webkit.org/284821@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list