[webkit-changes] [WebKit/WebKit] 78cf09: Remove duplicate copy of WebKitLegacy's umbrella h...

[Elliott Williams]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 78cf09d8967cc0492b530008ca9be149dae157e1
      https://github.com/WebKit/WebKit/commit/78cf09d8967cc0492b530008ca9be149dae157e1
  Author: Elliott Williams <emw at apple.com>
  Date:   2024-10-02 (Wed, 02 Oct 2024)

  Changed paths:
    M Source/WebKit/MigratedHeaders-input.xcfilelist
    M Source/WebKit/MigratedHeaders-output.xcfilelist
    R Source/WebKit/Shared/API/Cocoa/WebKitLegacy.h
    M Source/WebKit/WebKit.xcodeproj/project.pbxproj
    M Source/WebKitLegacy/scripts/xcfilelist-copy.py

  Log Message:
  -----------
  Remove duplicate copy of WebKitLegacy's umbrella header
https://bugs.webkit.org/show_bug.cgi?id=280374
rdar://problem/136718263

Reviewed by Alexey Proskuryakov.

In https://commits.webkit.org/248836@main, we made a copy of the
<WebKitLegacy/WebKit.h> umbrella header which is migrated to WebKit. I
said that:

    Xcode's header maps forbid a header's name from changing during the
    copy process, so we have to duplicate WebKitLegacy's umbrella header
    instead of renaming it WebKit.h -> WebKitLegacy.h during the build.

Later, in https://commits.webkit.org/259916@main, we moved from a pure
Xcode-project based header migration logic, to the current approach
where we have a pair of xcfilelists and a copying script. So, the "can't
rename WebKit.h" rule no longer applies. Delete this duplicated file and
teach xcfilelist-copy.py to rename <WebKitLegacy/WebKit.h> to
<WebKit/WebKitLegacy.h>.

* Source/WebKit/MigratedHeaders-input.xcfilelist:
* Source/WebKit/MigratedHeaders-output.xcfilelist:
* Source/WebKit/Shared/API/Cocoa/WebKitLegacy.h: Removed.
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Source/WebKitLegacy/scripts/xcfilelist-copy.py:

Canonical link: https://commits.webkit.org/284585@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications