[webkit-changes] [WebKit/WebKit] c1771f: [FFC] Fix flex line position for align-content: st...

Alan Baradlay noreply at github.com
Wed Oct 2 15:26:03 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c1771f8eee5ce846b3ac8d612766a04d77b26c82
      https://github.com/WebKit/WebKit/commit/c1771f8eee5ce846b3ac8d612766a04d77b26c82
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2024-10-02 (Wed, 02 Oct 2024)

  Changed paths:
    M Source/WebCore/layout/formattingContexts/flex/FlexFormattingContext.cpp
    M Source/WebCore/layout/formattingContexts/flex/FlexFormattingUtils.cpp
    M Source/WebCore/layout/formattingContexts/flex/FlexFormattingUtils.h
    M Source/WebCore/layout/formattingContexts/flex/FlexLayout.cpp
    M Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp

  Log Message:
  -----------
  [FFC] Fix flex line position for align-content: start/end when flex lines are reversed
https://bugs.webkit.org/show_bug.cgi?id=280758

Reviewed by Antti Koivisto.

Start and End flip when lines are reversed (as opposed to FlexStart and FlexEnd).
This patch also stops stretching lines when ContentDistribution is Normal (only ContentDistribution::Stretch is supposed to stretch flex lines to cover available cross axis space).

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebCore/layout/formattingContexts/flex/FlexFormattingUtils.cpp:
(WebCore::Layout::FlexFormattingUtils::isMainReversedToContentDirection):
(WebCore::Layout::FlexFormattingUtils::areFlexLinesReversedInCrossAxis):
(WebCore::Layout::FlexFormattingUtils::isReversedToContentDirection): Deleted.
* Source/WebCore/layout/formattingContexts/flex/FlexFormattingUtils.h:
* Source/WebCore/layout/formattingContexts/flex/FlexLayout.cpp:
(WebCore::Layout::FlexLayout::handleMainAxisAlignment const):
(WebCore::Layout::FlexLayout::handleCrossAxisAlignmentForFlexLines const):
* Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp:
(WebCore::LayoutIntegration::canUseForFlexLayoutWithReason):

Canonical link: https://commits.webkit.org/284584@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list