[webkit-changes] [WebKit/WebKit] f486c2: [visionOS] Tapping on "View Spatial" button does n...

[Jean-Yves Avenard]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f486c204f4ddd3eea2bf3810ad80e2656766fbcb
      https://github.com/WebKit/WebKit/commit/f486c204f4ddd3eea2bf3810ad80e2656766fbcb
  Author: Jean-Yves Avenard <jya at apple.com>
  Date:   2024-11-04 (Mon, 04 Nov 2024)

  Changed paths:
    M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm
    M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm

  Log Message:
  -----------
  [visionOS] Tapping on "View Spatial" button does not work in first go.
https://bugs.webkit.org/show_bug.cgi?id=282523
rdar://138883315

Reviewed by Jer Noble.

As soon as we exit spatial portal, the element fullscreen button in the top rows were showing.
There actions however wouldn't start until we have fully completed the operation of exiting fullscreen.

We now hide the buttons as soon as they have been pressed and will only show them again once the content process
has notified the UI process that the operation has been completed.

Manually tested.

* Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm:
(-[WKFullScreenViewController _enterVideoFullscreenAction:]):
* Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:
(-[WKFullScreenWindowController didCleanupFullscreen]):

Canonical link: https://commits.webkit.org/286130@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications