[webkit-changes] [WebKit/WebKit] fc1700: Ensure ReadOperation and WriteOperation store isol...

[Sihui]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fc170079c9018cb8b30554b7546d8bbac30cf3fa
      https://github.com/WebKit/WebKit/commit/fc170079c9018cb8b30554b7546d8bbac30cf3fa
  Author: Sihui Liu <sihui_liu at apple.com>
  Date:   2024-11-04 (Mon, 04 Nov 2024)

  Changed paths:
    M Source/WebKit/NetworkProcess/cache/NetworkCacheKey.h
    M Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.cpp
    M Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.h

  Log Message:
  -----------
  Ensure ReadOperation and WriteOperation store isolated copy of NetworkCache::Key
https://bugs.webkit.org/show_bug.cgi?id=282557
rdar://139230278

Reviewed by Chris Dumez.

The record keys in ReadOperation and WriteOperation are accessed from different threads, see tasks dispatched to
ioQueue() and backgroundIOQueue() , so we need to make sure they don't contain AtomString.

* Source/WebKit/NetworkProcess/cache/NetworkCacheKey.h:
(WebKit::NetworkCache::Key::isolatedCopy const):
* Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.cpp:
(WebKit::NetworkCache::Storage::ReadOperation::ReadOperation):
(WebKit::NetworkCache::Storage::WriteOperation::WriteOperation):
(WebKit::NetworkCache::Storage::readRecord):
* Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.h:
(WebKit::NetworkCache::Storage::Record::isolatedCopy const):

Canonical link: https://commits.webkit.org/286129@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications