[webkit-changes] [WebKit/WebKit] 8f05ce: [WGSL] textureGather is missing validation

Tadeu Zagallo noreply at github.com
Mon May 27 03:35:38 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8f05ced05e3ddafe3629b900b6c001fc658eb3ff
      https://github.com/WebKit/WebKit/commit/8f05ced05e3ddafe3629b900b6c001fc658eb3ff
  Author: Tadeu Zagallo <tzagallo at apple.com>
  Date:   2024-05-27 (Mon, 27 May 2024)

  Changed paths:
    M Source/WebGPU/WGSL/TypeCheck.cpp
    A Source/WebGPU/WGSL/tests/invalid/texture-gather.wgsl

  Log Message:
  -----------
  [WGSL] textureGather is missing validation
https://bugs.webkit.org/show_bug.cgi?id=274668
rdar://128664891

Reviewed by Mike Wyrzykowski.

We were missing the validation that when the first argument to `textureGather`
is the integer "component" argument, it must be a constant value between 0 and 3.

* Source/WebGPU/WGSL/TypeCheck.cpp:
(WGSL::TypeChecker::visit):
* Source/WebGPU/WGSL/tests/invalid/texture-gather.wgsl: Added.

Canonical link: https://commits.webkit.org/279345@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list