[webkit-changes] [WebKit/WebKit] be5f6e: [WGSL] shader, execution, expression, call, builtin, wo...

Tadeu Zagallo noreply at github.com
Mon May 27 03:18:51 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: be5f6ee9c8bcc433a04a56e60d982dd3d2948a8f
      https://github.com/WebKit/WebKit/commit/be5f6ee9c8bcc433a04a56e60d982dd3d2948a8f
  Author: Tadeu Zagallo <tzagallo at apple.com>
  Date:   2024-05-27 (Mon, 27 May 2024)

  Changed paths:
    A LayoutTests/http/tests/webgpu/webgpu/shader/execution/expression/call/builtin/workgroupUniformLoad-expected.txt
    M Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp
    M Source/WebGPU/WGSL/TypeDeclarations.rb

  Log Message:
  -----------
  [WGSL] shader,execution,expression,call,builtin,workgroupUniformLoad:* is failing
https://bugs.webkit.org/show_bug.cgi?id=274666
rdar://128691118

Reviewed by Mike Wyrzykowski.

There was a typo in the type declaration and a bug ni the metal code generator that
emitted a type constructor even when the resolved overload wasn't one.

* LayoutTests/http/tests/webgpu/webgpu/shader/execution/expression/call/builtin/workgroupUniformLoad-expected.txt: Added.
* Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp:
(WGSL::Metal::FunctionDefinitionWriter::visit):
* Source/WebGPU/WGSL/TypeDeclarations.rb:

Canonical link: https://commits.webkit.org/279344@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list