[webkit-changes] [WebKit/WebKit] d35627: Add bytes() to Blob and PushMessageData

Anne van Kesteren noreply at github.com
Fri May 24 05:43:45 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d35627646eb3b30079f2ec5bbbc75b02b2eb4e2b
      https://github.com/WebKit/WebKit/commit/d35627646eb3b30079f2ec5bbbc75b02b2eb4e2b
  Author: Anne van Kesteren <annevk at annevk.nl>
  Date:   2024-05-24 (Fri, 24 May 2024)

  Changed paths:
    M LayoutTests/http/wpt/push-api/pushEvent.any.js
    M LayoutTests/imported/w3c/web-platform-tests/FileAPI/Blob-methods-from-detached-frame-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/FileAPI/Blob-methods-from-detached-frame.html
    A LayoutTests/imported/w3c/web-platform-tests/FileAPI/blob/Blob-bytes.any-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/FileAPI/blob/Blob-bytes.any.html
    A LayoutTests/imported/w3c/web-platform-tests/FileAPI/blob/Blob-bytes.any.js
    A LayoutTests/imported/w3c/web-platform-tests/FileAPI/blob/Blob-bytes.any.worker-expected.txt
    A LayoutTests/imported/w3c/web-platform-tests/FileAPI/blob/Blob-bytes.any.worker.html
    M LayoutTests/imported/w3c/web-platform-tests/FileAPI/blob/w3c-import.log
    M Source/WebCore/Modules/push-api/PushMessageData.cpp
    M Source/WebCore/Modules/push-api/PushMessageData.h
    M Source/WebCore/Modules/push-api/PushMessageData.idl
    M Source/WebCore/fileapi/Blob.cpp
    M Source/WebCore/fileapi/Blob.h
    M Source/WebCore/fileapi/Blob.idl

  Log Message:
  -----------
  Add bytes() to Blob and PushMessageData
https://bugs.webkit.org/show_bug.cgi?id=274119
rdar://128418858

Reviewed by Youenn Fablet.

This implements https://github.com/w3c/FileAPI/pull/198 and
https://github.com/w3c/push-api/pull/370 creating parity for these
APIs with Fetch's Body.

This incorporates the tests from
https://github.com/web-platform-tests/wpt/pull/46232 modulo a typo fix.
PushMessageData test coverage is done through a local test that would
be good to upstream at some point.

* LayoutTests/http/wpt/push-api/pushEvent.any.js:
(test):
* LayoutTests/imported/w3c/web-platform-tests/FileAPI/Blob-methods-from-detached-frame-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/FileAPI/Blob-methods-from-detached-frame.html:
* LayoutTests/imported/w3c/web-platform-tests/FileAPI/blob/Blob-bytes.any-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/FileAPI/blob/Blob-bytes.any.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/FileAPI/blob/Blob-bytes.any.js: Added.
(string_appeared_here.promise_test.async const):
* LayoutTests/imported/w3c/web-platform-tests/FileAPI/blob/Blob-bytes.any.worker-expected.txt: Added.
* LayoutTests/imported/w3c/web-platform-tests/FileAPI/blob/Blob-bytes.any.worker.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/FileAPI/blob/w3c-import.log:
* Source/WebCore/Modules/push-api/PushMessageData.cpp:
(WebCore::PushMessageData::arrayBuffer):
(WebCore::PushMessageData::bytes):
* Source/WebCore/Modules/push-api/PushMessageData.h:
* Source/WebCore/Modules/push-api/PushMessageData.idl:
* Source/WebCore/fileapi/Blob.cpp:
(WebCore::Blob::arrayBuffer):
(WebCore::Blob::bytes):
* Source/WebCore/fileapi/Blob.h:
* Source/WebCore/fileapi/Blob.idl:

Canonical link: https://commits.webkit.org/279263@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list