[webkit-changes] [WebKit/WebKit] 083dc3: [WGSL] Function parameters have incorrect scope

[Tadeu Zagallo]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 083dc3ea78f47e88b2e48f4253e9f8248fdf95e9
      https://github.com/WebKit/WebKit/commit/083dc3ea78f47e88b2e48f4253e9f8248fdf95e9
  Author: Tadeu Zagallo <tzagallo at apple.com>
  Date:   2024-05-24 (Fri, 24 May 2024)

  Changed paths:
    M Source/WebGPU/WGSL/TypeCheck.cpp
    A Source/WebGPU/WGSL/tests/invalid/shadowing.wgsl

  Log Message:
  -----------
  [WGSL] Function parameters have incorrect scope
https://bugs.webkit.org/show_bug.cgi?id=274602
rdar://128625182

Reviewed by Mike Wyrzykowski.

The parameters were being placed in a separate scope from the function local variables,
allowing a local variable to shadow a parameter, which shouldn't be valid according to
the spec.

* Source/WebGPU/WGSL/TypeCheck.cpp:
(WGSL::TypeChecker::visit):
* Source/WebGPU/WGSL/tests/invalid/shadowing.wgsl: Added.

Canonical link: https://commits.webkit.org/279262@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications