[webkit-changes] [WebKit/WebKit] 74313d: [git-webkit] Add screen-reader friendly review wiz...

[Jonathan Bedard]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 74313d0521aae7fbcd8c8a287b92f924f34ce34c
      https://github.com/WebKit/WebKit/commit/74313d0521aae7fbcd8c8a287b92f924f34ce34c
  Author: Jonathan Bedard <jbedard at apple.com>
  Date:   2024-05-23 (Thu, 23 May 2024)

  Changed paths:
    M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/review.py
    M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/review_unittest.py

  Log Message:
  -----------
  [git-webkit] Add screen-reader friendly review wizard (Part 2)
https://bugs.webkit.org/show_bug.cgi?id=261242
rdar://115083100

Reviewed by Andres Gonzalez and Elliott Williams.

Allow user to review and comment on a pull request by editing a local file.

* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/review.py:
(Review.truncate_strs): Turn a nested dictionary of strings into a nested dictionary
of lists of string based on where newline are in strings.
(Review.user_delta): Detect which users have been added or removed from a list of users.
(Review.invoke_wizard): Diff the original file with a user's local edits and return those
local edits to be converted into actions on a pull request.
(Review.main): Given the difference returned by invoke_wizard, programatically add comments,
change pull request metadata and approve (or reject) the pull request.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/review_unittest.py:
(TestReview.editor_callback):
(TestReview.editor_callback.callback):
(TestReview.test_truncate_strs):
(TestReview.test_user_delta_github):
(TestReview.test_user_delta_bitbucket):
(TestReview.test_edit_metadata):
(TestReview.test_comment_commit_message):
(TestReview.test_comment):
(TestReview.test_comment_reply):
(TestReview.test_comment_reply_only_one):
(TestReview.test_comment_reply_both):
(TestReview.test_diff_file_comment):
(TestReview.test_diff_inline_comment):
(TestReview.test_github_read_comments):
(TestReview.test_bitbucket_no_edit):
(TestReview.test_github_no_edit):
(TestReview.test_bitbucket_approve):
(TestReview.test_github_deny):
(TestReview.test_bitbucket_edit_deny):
(TestReview.test_github_edit_approve):
(TestReview.test_bitbucket_edit_refresh):
(TestReview.test_github_edit_refresh):
(TestReview.test_bitbucket_edit_comment):
(TestReview.test_github_edit_comment):
(TestReview.test_bitbucket_edit_comment_commit_message):
(TestReview.test_github_edit_comment_commit_message):
(TestReview.test_bitbucket_edit_comment_inline_diff):
(TestReview.test_github_edit_comment_inline_diff):
(TestReview.test_bitbucket_edit_title):
(TestReview.test_github_edit_title):
(TestReview.test_bitbucket_edit_open):
(TestReview.test_github_edit_close):
(TestReview.test_bitbucket_edit_merged_close):
(TestReview.test_github_edit_merged_open):
(TestReview.test_bitbucket_add_labels):
(TestReview.test_github_edit_labels):
(TestReview.test_github_edit_invalid_labels):

Canonical link: https://commits.webkit.org/279255@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications