[webkit-changes] [WebKit/WebKit] 7b0ca1: [run-webkit-tests] Route media tests to a mutually...

Jonathan Bedard noreply at github.com
Tue May 21 15:28:46 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 7b0ca1365193adda601a2af7d1c2a53a913b21c6
      https://github.com/WebKit/WebKit/commit/7b0ca1365193adda601a2af7d1c2a53a913b21c6
  Author: Jonathan Bedard <jbedard at apple.com>
  Date:   2024-05-21 (Tue, 21 May 2024)

  Changed paths:
    M Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py
    M Tools/Scripts/webkitpy/port/base.py
    M Tools/Scripts/webkitpy/port/darwin.py
    M Tools/Scripts/webkitpy/port/darwin_testcase.py
    M Tools/Scripts/webkitpy/port/port_testcase.py

  Log Message:
  -----------
  [run-webkit-tests] Route media tests to a mutually exclusive group
https://bugs.webkit.org/show_bug.cgi?id=273797
rdar://127629496

Reviewed by Sam Sneddon.

We have evidence that media tests can interfere with one another. We should run media
tests in a dedicated worker so that these tests never interfere with other media tests.

* Tools/Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
(LayoutTestRunner.run_tests): Use groups as defined by the current port. Dispatch grouped shards
first, so that we aren't waiting on groups at the end of the test run.
(TestShard.__init__): Support empty test list.
* Tools/Scripts/webkitpy/port/base.py:
(Port.sharding_groups): Return all groups and their callback definitions.
(Port.group_for_shard): Given a shard, return the group that shard is part of.
* Tools/Scripts/webkitpy/port/darwin.py:
(DarwinPort.sharding_groups): Add dedicated 'media' and 'mediacapture' groups for all shards
containing a media or mediacapture tests.
* Tools/Scripts/webkitpy/port/darwin_testcase.py:
(DarwinTest.test_lanes):
* Tools/Scripts/webkitpy/port/port_testcase.py:
(PortTestCase.test_lanes):

Canonical link: https://commits.webkit.org/279079@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list