[webkit-changes] [WebKit/WebKit] b21235: Text not visible after undo-ing UnifiedTextReplace...

megangardner noreply at github.com
Tue May 21 15:07:45 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b21235bb8e7dd9fcec5d6420bbbec4f9d3a2215f
      https://github.com/WebKit/WebKit/commit/b21235bb8e7dd9fcec5d6420bbbec4f9d3a2215f
  Author: Megan Gardner <megan_gardner at apple.com>
  Date:   2024-05-21 (Tue, 21 May 2024)

  Changed paths:
    M Source/WebCore/dom/DocumentMarkerController.h
    M Source/WebKit/WebProcess/WebPage/Cocoa/UnifiedTextReplacementController.mm

  Log Message:
  -----------
  Text not visible after undo-ing UnifiedTextReplacement.
https://bugs.webkit.org/show_bug.cgi?id=274427
rdar://128292480

Reviewed by Wenson Hsieh and Aditya Keerthi.

We were only clearing document markers in a specific range,
but after text has been replaced, those nodes might not be
in that range any longer. Just clear all the markers associated
with an ID, regardless of location.

* Source/WebCore/dom/DocumentMarkerController.h:
* Source/WebKit/WebProcess/WebPage/Cocoa/UnifiedTextReplacementController.mm:
(WebKit::UnifiedTextReplacementController::removeTransparentMarkersForUUID):

Canonical link: https://commits.webkit.org/279078@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list