[webkit-changes] [WebKit/WebKit] a19c25: [WebGPU] A12x devices and earlier allowed for crea...

mwyrzykowski noreply at github.com
Mon May 20 15:02:29 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a19c25f387d25390c062e22d4b56e32a275ef274
      https://github.com/WebKit/WebKit/commit/a19c25f387d25390c062e22d4b56e32a275ef274
  Author: Mike Wyrzykowski <mwyrzykowski at apple.com>
  Date:   2024-05-20 (Mon, 20 May 2024)

  Changed paths:
    M LayoutTests/TestExpectations
    A LayoutTests/fast/webgpu/fuzz-274334-expected.txt
    A LayoutTests/fast/webgpu/fuzz-274334.html
    M Source/WebGPU/WebGPU/HardwareCapabilities.mm

  Log Message:
  -----------
  [WebGPU] A12x devices and earlier allowed for creation of more samplers than supported by the HW
https://bugs.webkit.org/show_bug.cgi?id=274334
<radar://128065020>

Reviewed by Dan Glastonbury.

Apple4 and Apple5 devices have Tier 1 AB support, not tier 2, but
their limits were set according to tier 1 limits.

These are mostly older phones and iPads (iPhone XS, 2018 iPad Pro),
so we can instead use the default WebGPU limits which many websites
may use in any case.

Apple3 is not supported by WebGPU core, rather only WebGPU compat mode, which we
don't have any validation for right now.

* LayoutTests/fast/webgpu/fuzz-274334-expected.txt: Added.
* LayoutTests/fast/webgpu/fuzz-274334.html: Added.
* LayoutTests/TestExpectations
Add regression test.

* Source/WebGPU/WebGPU/HardwareCapabilities.mm:
(WebGPU::rawHardwareCapabilities):
(WebGPU::apple3): Deleted.
(WebGPU::apple4): Deleted.
(WebGPU::apple5): Deleted.
Use default limits for Apple3/4/5

Canonical link: https://commits.webkit.org/279016@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list