[webkit-changes] [WebKit/WebKit] d17d81: JSC stress test stack-overflow-in-syntax-checker.j...

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d17d81bc253da984c67d02f70989fc7005454e45
      https://github.com/WebKit/WebKit/commit/d17d81bc253da984c67d02f70989fc7005454e45
  Author: Mark Lam <mark.lam at apple.com>
  Date:   2024-05-20 (Mon, 20 May 2024)

  Changed paths:
    M JSTests/stress/stack-overflow-in-syntax-checker.js

  Log Message:
  -----------
  JSC stress test stack-overflow-in-syntax-checker.js is flaky.
https://bugs.webkit.org/show_bug.cgi?id=274411
rdar://124472916

Reviewed by Alexey Shvayka.

The test sometimes fail on macOS bots with this output in stdio:
```
stress/stack-overflow-in-syntax-checker.js.default: Exception: RangeError: Maximum call stack size exceeded.
stress/stack-overflow-in-syntax-checker.js.default: ERROR: Unexpected exit code: 1
FAIL: stress/stack-overflow-in-syntax-checker.js.default
```

Exit code 1 on Apple platforms is EXIT_FAILURE.  From grepping the code, the only place that potentially
exits with EXIT_FAILURE, and is exercised by the test is in the jsc shell's functionDollarAgentStart
function (aka $262.agent.start).  The exit with EXIT_FAILURE only manifests on the started agent thread
in response to an unhandled exception.

So, as a speculative fix, just add a try-catch block around the test payload that we run on that agent
thread.  The goal of the test is just to check if we crash on stack overflow, and not to check that
all exceptions are handled.  Hence, this speculative fix is appropriate for this test, and does not alter
its intent.

* JSTests/stress/stack-overflow-in-syntax-checker.js:
(try.262.agent.start.try.262.agent.receiveBroadcast):
(try.catch):
(try.262.agent.start.262.agent.receiveBroadcast): Deleted.

Canonical link: https://commits.webkit.org/279015@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications