[webkit-changes] [WebKit/WebKit] 29cddc: If torch is on on a track, muting and unmuting it ...

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 29cddce2522b69778bd95c60e2d9eb60bbd17714
      https://github.com/WebKit/WebKit/commit/29cddce2522b69778bd95c60e2d9eb60bbd17714
  Author: Youenn Fablet <youenn at apple.com>
  Date:   2024-05-17 (Fri, 17 May 2024)

  Changed paths:
    M Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm

  Log Message:
  -----------
  If torch is on on a track, muting and unmuting it will switch off the torch
https://bugs.webkit.org/show_bug.cgi?id=270840
rdar://124435440

Reviewed by Eric Carlson.

When restarting to capture, we were not setting back torch to what it should be.
This would trigger the issue of having torch on, muting capture, unmuting capture and having torch off.
We fix this by ensuring that torch is updated when (re)starting capture.

We do a drive-by fix in AVVideoCaptureSource::reconfigureIfNeeded.
We need to call startApplyingConstraints/endApplyingConstraints instead of beginConfiguration/commitConfiguration, to keep the balance.
Otherwise updateTorch would do an additional beginConfiguration call without any corresponding commitConfiguration.

* Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:
(WebCore::AVVideoCaptureSource::setupCaptureSession):
(WebCore::AVVideoCaptureSource::reconfigureIfNeeded):

Canonical link: https://commits.webkit.org/278948@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications