[webkit-changes] [WebKit/WebKit] 4b7d24: [Apple-Ventura-AppleSilicon-Debug-JSC-Tests] ASSER...

[Dan Hecht]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4b7d246d6d632f5297784b401e3d30153ac55bc7
      https://github.com/WebKit/WebKit/commit/4b7d246d6d632f5297784b401e3d30153ac55bc7
  Author: Dan Hecht <dan.hecht at apple.com>
  Date:   2024-05-17 (Fri, 17 May 2024)

  Changed paths:
    M Source/JavaScriptCore/dfg/DFGOperations.cpp

  Log Message:
  -----------
  [Apple-Ventura-AppleSilicon-Debug-JSC-Tests] ASSERTION FAILED: !m_needExceptionCheck in multiple tests in ChakraCore.yaml/ChakraCore/test
https://bugs.webkit.org/show_bug.cgi?id=274281
rdar://128228200

Reviewed by Keith Miller.

toStringOrNull() can throw an exception but no exception check occurs before calling
testInline() which can also throw.  However, according to the code in the similar func
operationRegExpTestGeneric(), toStringOrNull() only throws when !input, so we are
actually safe and would always bail on that path anyway. Document this and placate
the exception checker by adding an assert.

* Source/JavaScriptCore/dfg/DFGOperations.cpp:
(JSC::DFG::JSC_DEFINE_JIT_OPERATION):

Canonical link: https://commits.webkit.org/278947@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications