[webkit-changes] [WebKit/WebKit] 1e5a82: REGRESSION (278815 at main): [ MacOS iOS Debug ] Test...

[Wenson Hsieh]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1e5a82de122e187fb66f39af69abc2a35557b72c
      https://github.com/WebKit/WebKit/commit/1e5a82de122e187fb66f39af69abc2a35557b72c
  Author: Wenson Hsieh <wenson_hsieh at apple.com>
  Date:   2024-05-17 (Fri, 17 May 2024)

  Changed paths:
    M Source/WebCore/platform/audio/AudioUtilities.cpp

  Log Message:
  -----------
  REGRESSION (278815 at main): [ MacOS iOS Debug ] TestWebKitAPI.AdvancedPrivacyProtections.AddNoiseToWebAudioAPIs is a consistent failure
https://bugs.webkit.org/show_bug.cgi?id=274266
rdar://128209071

Reviewed by Chris Dumez.

Allocations are forbidden here for performance reasons:

```
void AudioDestinationNode::renderQuantum(…)
{
    …

    // For performance reasons, we forbid heap allocations while doing rendering on the audio thread.
    // Heap allocations that cannot be avoided or have not been fixed yet can be allowed using
    // DisableMallocRestrictionsForCurrentThreadScope scope variables.
    ForbidMallocUseForCurrentThreadScope forbidMallocUse;
```

When applying noise (in the case where Advanced Privacy Protections are enabled), honor this by
stack-allocating the noise multiplier buffer instead.

* Source/WebCore/platform/audio/AudioUtilities.cpp:
(WebCore::AudioUtilities::applyNoise):

Canonical link: https://commits.webkit.org/278945@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications