[webkit-changes] [WebKit/WebKit] 69eafe: Constructed FormData object should not contain ent...

[Commit Queue]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 69eafe9632cacda742ab4a042e2bc6836406d55d
      https://github.com/WebKit/WebKit/commit/69eafe9632cacda742ab4a042e2bc6836406d55d
  Author: Ahmad Saleem <ahmad.saleem792 at gmail.com>
  Date:   2024-05-17 (Fri, 17 May 2024)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/constructing-form-data-set-expected.txt
    M Source/WebCore/html/ImageInputType.cpp

  Log Message:
  -----------
  Constructed FormData object should not contain entries for the Image Button submitter by default

https://bugs.webkit.org/show_bug.cgi?id=274214

Reviewed by Chris Dumez.

This patch aligns WebKit with Gecko / Firefox and Blink / Chromium.

In 249999 at main, WebKit patched the issue for other input types while left out
`ImageInput`, this is to extend similar solution to `image` input.

Originally, when the activedSumbit flag is set for a image input, its value
is appeneded to a FormData. In the case of form submission in event handler,
we include this when build FormData, while we shouldn't. This removes the following
flag.

Original Patch Credits: Andreu Botella (andreu at andreubotella.com) in bug 234069

* Source/WebCore/html/ImageInputType.cpp:
(WebCore::ImageInputType::handleDOMActivateEvent):
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/constructing-form-data-set-expected.txt:

Canonical link: https://commits.webkit.org/278944@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications