[webkit-changes] [WebKit/WebKit] 479314: Style checker shouldn't complain about `requires (...

Keith Miller noreply at github.com
Fri May 17 12:09:15 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 479314b7018c909d99dcff4714b6ec2171652339
      https://github.com/WebKit/WebKit/commit/479314b7018c909d99dcff4714b6ec2171652339
  Author: Keith Miller <keith_miller at apple.com>
  Date:   2024-05-17 (Fri, 17 May 2024)

  Changed paths:
    M Tools/Scripts/webkitpy/style/checkers/cpp.py
    M Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py

  Log Message:
  -----------
  Style checker shouldn't complain about `requires (MyConcept)`
https://bugs.webkit.org/show_bug.cgi?id=274324
rdar://128284081

Reviewed by Jonathan Bedard.

Right now the style checker will complain about an extra space before the
arguments to a function call when you do `requires (MyConcept)`. We should
treat spaces after `requires` the same way we treat spaces after other keywords.

* Tools/Scripts/webkitpy/style/checkers/cpp.py:
(check_spacing_for_function_call):
* Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py:
(WebKitStyleTest.test_spacing):

Canonical link: https://commits.webkit.org/278922@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list