[webkit-changes] [WebKit/WebKit] a60827: [git-webkit] Handle core.hookspath

Jonathan Bedard noreply at github.com
Fri May 17 11:47:12 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a60827c76f1d4d54d0963a095b78d2dcd82d7753
      https://github.com/WebKit/WebKit/commit/a60827c76f1d4d54d0963a095b78d2dcd82d7753
  Author: Jonathan Bedard <jbedard at apple.com>
  Date:   2024-05-17 (Fri, 17 May 2024)

  Changed paths:
    M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/install_hooks.py
    M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/install_hooks_unittest.py

  Log Message:
  -----------
  [git-webkit] Handle core.hookspath
https://bugs.webkit.org/show_bug.cgi?id=274260
rdar://128152670

Reviewed by Dewei Zhu.

git doesn't always look for hooks in .git/hooks. We should handle the
case where core.hooksPath points somewhere else.

* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/install_hooks.py:
(InstallHooks.hook_needs_update): Check core.hooksPath for the specified hook.
(InstallHooks.main): Check if core.hooksPath matches the expected repository
hook location. If it doesn't, prompt the user for possible corrective actions.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/install_hooks_unittest.py:
(TestInstallHooks.test_install_hook_alternate_hook_path_change):
(TestInstallHooks.test_install_hook_alternate_hook_path_use):
(TestInstallHooks.test_install_hook_alternate_hook_path_exit):

Canonical link: https://commits.webkit.org/278921@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list