[webkit-changes] [WebKit/WebKit] a5ef58: Added default length to createGridTrackBreadth() w...

NKRosario noreply at github.com
Thu May 16 09:32:45 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a5ef58e83a90d4ed76c02770b5ffdd385901e847
      https://github.com/WebKit/WebKit/commit/a5ef58e83a90d4ed76c02770b5ffdd385901e847
  Author: Nicole Rosario <nicole_rosario at apple.com>
  Date:   2024-05-16 (Thu, 16 May 2024)

  Changed paths:
    A LayoutTests/fast/css-grid-layout/css-grid-template-rows-invalid-length-expected.txt
    A LayoutTests/fast/css-grid-layout/css-grid-template-rows-invalid-length.html
    M Source/WebCore/style/StyleBuilderConverter.h

  Log Message:
  -----------
  Added default length to createGridTrackBreadth() when length is undefined
https://bugs.webkit.org/show_bug.cgi?id=269856
rdar://119619013

Reviewed by Sammy Gill.

`convertToLength` returned length undefined to `createGridTrackBreadth`
which causes an issue when creating GridLength. Added check to see if
length is undefined and if so returned a default length = 0 instead

* Source/WebCore/style/StyleBuilderConverter.h:
(WebCore::Style::BuilderConverter::createGridTrackBreadth):

Originally-landed-as: 272448.626 at safari-7618-branch (0b6e28662a19). rdar://128091169
Canonical link: https://commits.webkit.org/278871@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list