[webkit-changes] [WebKit/WebKit] 332ec8: [JSC] AI should observe attribute change transitio...

Yijia Huang noreply at github.com
Thu May 16 09:31:51 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 332ec81baece8f72fadd3cb37ca079825c2e18fc
      https://github.com/WebKit/WebKit/commit/332ec81baece8f72fadd3cb37ca079825c2e18fc
  Author: Yijia Huang <yijia_huang at apple.com>
  Date:   2024-05-16 (Thu, 16 May 2024)

  Changed paths:
    A JSTests/stress/dfg-ai-direct-get-by-id-attribute-change-transition.js
    M Source/JavaScriptCore/bytecode/PutByStatus.cpp
    M Source/JavaScriptCore/runtime/Structure.cpp
    M Source/JavaScriptCore/runtime/Structure.h

  Log Message:
  -----------
  [JSC] AI should observe attribute change transitions for PutByIdDirect in DFG compilation
https://bugs.webkit.org/show_bug.cgi?id=270265
rdar://122515736

Reviewed by Yusuke Suzuki.

Since DirectPutById can trigger and cache attribute change transitions,
the AI should observe these kinds of transitions when computing for
GetByStatus in the DFG compilation.

* JSTests/stress/dfg-ai-attribute-change-transition-1.js: Added.
(returnObject):
(Opt):
(createObjectA):
(createObjectB):
(initialize):
* JSTests/stress/dfg-ai-attribute-change-transition-2.js: Added.
(returnObject):
(Opt):
(createObject):
(getStructureID):
(main):
* Source/JavaScriptCore/bytecode/PutByStatus.cpp:
(JSC::PutByStatus::computeFor):
* Source/JavaScriptCore/runtime/Structure.cpp:
(JSC::Structure::attributeChangeTransitionToExistingStructureImpl):
(JSC::Structure::attributeChangeTransitionToExistingStructure):
(JSC::Structure::attributeChangeTransitionToExistingStructureConcurrently):
* Source/JavaScriptCore/runtime/Structure.h:

Originally-landed-as: 272448.651 at safari-7618-branch (4e48bdad7045). rdar://128090341
Canonical link: https://commits.webkit.org/278870@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list