[webkit-changes] [WebKit/WebKit] cfbeda: Special case treatment of out-of-flow RenderLineBreak

[Žan Doberšek]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: cfbedad2b912fe2910a7de269bf055bbc60fcc00
      https://github.com/WebKit/WebKit/commit/cfbedad2b912fe2910a7de269bf055bbc60fcc00
  Author: Žan Doberšek <zdobersek at igalia.com>
  Date:   2024-05-16 (Thu, 16 May 2024)

  Changed paths:
    A LayoutTests/fast/css/line-break-fixed-position-container-expected.txt
    A LayoutTests/fast/css/line-break-fixed-position-container.html
    M Source/WebCore/rendering/RenderObject.cpp

  Log Message:
  -----------
  Special case treatment of out-of-flow RenderLineBreak
https://bugs.webkit.org/show_bug.cgi?id=264631
rdar://114719845

Reviewed by Alan Baradlay.

Out-of-flow RenderLineBreaks have problems when relying on default out-of-flow support of the render
tree, see https://bugs.webkit.org/show_bug.cgi?id=270977.

To fix the problem we change containerForElement and containingBlock to treat RenderLineBreak that are out-of-flow as
if they have position: static.

* LayoutTests/fast/css/line-break-fixed-position-container-expected.txt: Added.
* LayoutTests/fast/css/line-break-fixed-position-container.html: Added.
* Source/WebCore/rendering/RenderObject.cpp:
(WebCore::RenderObject::containingBlock const):
(WebCore::containerForElement):

Originally-landed-as: 274097.12 at webkit-2024.2-embargoed (5bd3a1c2b0ac). rdar://128088216
Canonical link: https://commits.webkit.org/278867@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications