[webkit-changes] [WebKit/WebKit] fc8a91: GetWebAssemblyInstanceExports nodes should not be ...

[Justin Michaud]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fc8a911ed08115172c50eac41b9ced4e3415d234
      https://github.com/WebKit/WebKit/commit/fc8a911ed08115172c50eac41b9ced4e3415d234
  Author: Justin Michaud <justin at justinmichaud.com>
  Date:   2024-05-16 (Thu, 16 May 2024)

  Changed paths:
    A JSTests/stress/hoist-get-wasm-exports.js
    M Source/JavaScriptCore/dfg/DFGSafeToExecute.h

  Log Message:
  -----------
  GetWebAssemblyInstanceExports nodes should not be blindly hoisted
https://bugs.webkit.org/show_bug.cgi?id=270259
rdar://123617167

Reviewed by Alexey Shvayka.

GetWebAssemblyInstanceExports nodes should not be blindly hoisted above
their structure check.

```
case WebAssemblyInstanceExportsIntrinsic:
    ...
    addToGraph(CheckStructure, OpInfo(m_graph.addStructureSet(variant.structureSet())), thisNode);
    set(result, addToGraph(GetWebAssemblyInstanceExports, Edge(thisNode, KnownCellUse)));
```

Similar to GetByOffset, we should only hoist this node if we have proven
that the child has the structure of a WebAssembly Instance.

* JSTests/stress/hoist-get-wasm-exports.js: Added.
(opt):
(main):
* Source/JavaScriptCore/dfg/DFGSafeToExecute.h:
(JSC::DFG::safeToExecute):

Originally-landed-as: 272448.653 at safari-7618-branch (f6e2c3bb0a72). rdar://128090197
Canonical link: https://commits.webkit.org/278866@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications