[webkit-changes] [WebKit/WebKit] a1b3b9: Versioning.

Tue May 14 16:13:27 PDT 2024

  Branch: refs/heads/safari-7617.2.4.10-branch
  Home:   https://github.com/WebKit/WebKit
  Commit: a1b3b9269e4aa9975615e90f7e3e27f5952fe3aa
      https://github.com/WebKit/WebKit/commit/a1b3b9269e4aa9975615e90f7e3e27f5952fe3aa
  Author: Dan Robson <dtr_bugzilla at apple.com>
  Date:   2023-12-19 (Tue, 19 Dec 2023)

  Changed paths:
    M Configurations/Version.xcconfig

  Log Message:
  -----------
  Versioning.

WebKit-617.2.4.10.1

Canonical link: https://commits.webkit.org/267815.657@safari-7617.2.4.10-branch

  Commit: 1e43d51dc3360a8c5a2eedf22be984a3432203a5
      https://github.com/WebKit/WebKit/commit/1e43d51dc3360a8c5a2eedf22be984a3432203a5
  Author: Russell Epstein <repstein at apple.com>
  Date:   2023-12-19 (Tue, 19 Dec 2023)

  Changed paths:
    M Configurations/Version.xcconfig

  Log Message:
  -----------
  Versioning.

WebKit-7617.2.4.10.2

Canonical link: https://commits.webkit.org/267815.658@safari-7617.2.4.10-branch

  Commit: 9cd47571a06aa443606927f488ba49cc6509d583
      https://github.com/WebKit/WebKit/commit/9cd47571a06aa443606927f488ba49cc6509d583
  Author: Dan Robson <dtr_bugzilla at apple.com>
  Date:   2023-12-20 (Wed, 20 Dec 2023)

  Changed paths:
    M Configurations/Version.xcconfig

  Log Message:
  -----------
  Versioning.

WebKit-617.2.4.10.3

Canonical link: https://commits.webkit.org/267815.659@safari-7617.2.4.10-branch

  Commit: 37b6557add49a84b16e19a6b212cdaa995a2ffe9
      https://github.com/WebKit/WebKit/commit/37b6557add49a84b16e19a6b212cdaa995a2ffe9
  Author: Dan Robson <dtr_bugzilla at apple.com>
  Date:   2023-12-20 (Wed, 20 Dec 2023)

  Changed paths:
    M Source/WebCore/Modules/encryptedmedia/MediaKeySystemRequest.cpp
    M Source/WebCore/Modules/encryptedmedia/MediaKeySystemRequest.h
    M Source/WebCore/Modules/encryptedmedia/NavigatorEME.cpp
    M Source/WebKit/UIProcess/MediaKeySystemPermissionRequestManagerProxy.cpp
    M Source/WebKit/WebProcess/EncryptedMedia/MediaKeySystemPermissionRequestManager.cpp
    M Source/WebKit/WebProcess/EncryptedMedia/MediaKeySystemPermissionRequestManager.h
    M Source/WebKit/WebProcess/WebPage/WebPage.cpp
    M Source/WebKit/WebProcess/WebPage/WebPage.h
    M Source/WebKit/WebProcess/WebPage/WebPage.messages.in
    M Source/WebKitLegacy/mac/WebCoreSupport/WebMediaKeySystemClient.mm

  Log Message:
  -----------
  Cherry-pick 2bee8872e3b9. rdar://118004786

    REGRESSION (233845 at main): Crash in MediaKeySystemRequest::~MediaKeySystemRequest
    https://bugs.webkit.org/show_bug.cgi?id=266619
    rdar://118004786

    Reviewed by Jean-Yves Avenard.

    In 233845 at main, NavigatorEME::requestMediaKeySystemAccess moved the task that creates the CDM
    instance into a completion handler that's called asynchronously once the client allows media key
    access. The completion handler captured a raw pointer to the document, leading to a crash if the
    document is destroyed before the completion handler is called. Debug builds would also assert in
    CompletionHandler::~CompletionHandler because ActiveDOMObject::queueTaskInEventLoop would not
    invoke the task queued by MediaKeySystemRequest::allow - which captured a CompletionHandler - when
    scriptExecutionContext is null.

    Addressed the crash by capturing document as a WeakPtr and null-checking it prior to calling
    Document::postTask in NavigatorEME::requestMediaKeySystemAccess's allow callback. Addressed the
    assertion failure by removing the unnecessary asynchronous CompletionHandler from
    Messages::WebPage::MediaKeySystemWasGranted.

    * Source/WebCore/Modules/encryptedmedia/MediaKeySystemRequest.cpp:
    (WebCore::MediaKeySystemRequest::allow):
    * Source/WebCore/Modules/encryptedmedia/MediaKeySystemRequest.h:
    * Source/WebCore/Modules/encryptedmedia/NavigatorEME.cpp:
    (WebCore::NavigatorEME::requestMediaKeySystemAccess):
    * Source/WebKit/UIProcess/MediaKeySystemPermissionRequestManagerProxy.cpp:
    (WebKit::MediaKeySystemPermissionRequestManagerProxy::grantRequest):
    * Source/WebKit/WebProcess/EncryptedMedia/MediaKeySystemPermissionRequestManager.cpp:
    (WebKit::MediaKeySystemPermissionRequestManager::mediaKeySystemWasGranted):
    * Source/WebKit/WebProcess/EncryptedMedia/MediaKeySystemPermissionRequestManager.h:
    * Source/WebKit/WebProcess/WebPage/WebPage.cpp:
    (WebKit::WebPage::mediaKeySystemWasGranted):
    * Source/WebKit/WebProcess/WebPage/WebPage.h:
    * Source/WebKit/WebProcess/WebPage/WebPage.messages.in:
    * Source/WebKitLegacy/mac/WebCoreSupport/WebMediaKeySystemClient.mm:
    (WebMediaKeySystemClient::requestMediaKeySystem):

    Canonical link: https://commits.webkit.org/267815.655@safari-7617-branch

Canonical link: https://commits.webkit.org/267815.660@safari-7617.2.4.10-branch

  Commit: 6073ac55bcff2222c557b9833dc53f1753f52d6a
      https://github.com/WebKit/WebKit/commit/6073ac55bcff2222c557b9833dc53f1753f52d6a
  Author: Dan Robson <dtr_bugzilla at apple.com>
  Date:   2023-12-20 (Wed, 20 Dec 2023)

  Changed paths:
    M Source/WebKit/NetworkProcess/storage/NetworkStorageManager.cpp

  Log Message:
  -----------
  Cherry-pick 64a739754a58. rdar://117839300

    Ensure NetworkStorageManager gets destroyed on the main thread
    https://bugs.webkit.org/show_bug.cgi?id=266603
    rdar://117839300

    Reviewed by Chris Dumez and Alex Christensen.

    Dispatch a task to main thread to release ref of NetworkStorageManager in stopReceivingMessageFromConnection, which may
    help fix the crash under IDBStorageRegistry::removeConnectionToClient in rdar://117839300.

    * Source/WebKit/NetworkProcess/storage/NetworkStorageManager.cpp:
    (WebKit::NetworkStorageManager::stopReceivingMessageFromConnection):

    Canonical link: https://commits.webkit.org/272313@main

Canonical link: https://commits.webkit.org/267815.661@safari-7617.2.4.10-branch

  Commit: b1eaa7c478cb33d009a27270dc96ae120c36de67
      https://github.com/WebKit/WebKit/commit/b1eaa7c478cb33d009a27270dc96ae120c36de67
  Author: Russell Epstein <repstein at apple.com>
  Date:   2023-12-21 (Thu, 21 Dec 2023)

  Changed paths:
    M Configurations/Version.xcconfig

  Log Message:
  -----------
  Versioning.

WebKit-7617.2.4.10.4

Canonical link: https://commits.webkit.org/267815.662@safari-7617.2.4.10-branch

  Commit: fb813941d84f9a614067839a9ce28bb7b583daaa
      https://github.com/WebKit/WebKit/commit/fb813941d84f9a614067839a9ce28bb7b583daaa
  Author: Russell Epstein <repstein at apple.com>
  Date:   2023-12-21 (Thu, 21 Dec 2023)

  Changed paths:
    M Source/WebKit/UIProcess/WebProcessPool.cpp
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm

  Log Message:
  -----------
  Cherry-pick c839c8024f77. rdar://117891282

    URL scheme handler is not used when redirecting from http(s) to the custom scheme
    https://bugs.webkit.org/show_bug.cgi?id=266751
    rdar://117891282

    Reviewed by John Wilander and Alex Christensen.

    We updated our process-swapping logic in a recent iOS update and it broke the flow
    to add a new payment method in some cases. The flow navigates from a https:// URL
    to a another scheme which the client app is supposed to handle via a URL scheme
    handler. In older iOS version, we used to process-swap for such navigations and
    the navigation in the new WebProcess would correctly use the URL scheme handler.

    However, in newer iOS versions, we sometimes don't process-swap. This is the case
    for example when the process has not committed a provisional load yet. Because
    we don't process-swap, the redirect happens in the old process, the URL scheme
    handler is not used and we ask the network to try and follow the redirect, which
    fails.

    To address the issue, I am adding a check in processForNavigationInternal() to
    make sure we process-swap when redirecting to a new scheme and this scheme has a
    custom handler registered.

    This is covered by a new API test.

    * Source/WebKit/UIProcess/WebProcessPool.cpp:
    (WebKit::WebProcessPool::processForNavigationInternal):
    * Tools/TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:

    Canonical link: https://commits.webkit.org/272427@main

Canonical link: https://commits.webkit.org/267815.663@safari-7617.2.4.10-branch

  Commit: 62b5591dd0001e519517d58accaf1471f8ec98d6
      https://github.com/WebKit/WebKit/commit/62b5591dd0001e519517d58accaf1471f8ec98d6
  Author: Myah Cobbs <mcobbs at apple.com>
  Date:   2024-01-02 (Tue, 02 Jan 2024)

  Changed paths:
    M Configurations/Version.xcconfig

  Log Message:
  -----------
  Versioning.

WebKit-7617.2.4.10.5

Identifier: 267815.664 at safari-7617.2.4.10-branch

  Commit: c3c2a42ade132ffa93ed351556aea716de47c358
      https://github.com/WebKit/WebKit/commit/c3c2a42ade132ffa93ed351556aea716de47c358
  Author: Sihui Liu <sihui_liu at apple.com>
  Date:   2024-01-02 (Tue, 02 Jan 2024)

  Changed paths:
    M Source/WebCore/bindings/js/SerializedScriptValue.cpp
    M Source/WebCore/bindings/js/SerializedScriptValue.h

  Log Message:
  -----------
  Safari's IndexedDB data may not be deserialized correctly after system upgrades
https://bugs.webkit.org/show_bug.cgi?id=266806
rdar://120031024

Reviewed by NOBODY (OOPS!).

To fix rdar://119834827, we introduce version 12.1 to SerializeScriptValue, which changed the terminator of the indexed
property section in array compared to version 12. To make sure deserializer knows to deserialize version 12.1, we encode
the minor version in the highest 8 bits of version number. We keep the lowest 24 bit as major version number for
backward compatibility (the previously stored 32-bit major version number can be intepreted as major version with minor
version 0).

* Source/WebCore/bindings/js/SerializedScriptValue.cpp:
(WebCore::majorVersionFor):
(WebCore::minorVersionFor):
(WebCore::makeVersion):
(WebCore::currentVersion):
(WebCore::CloneSerializer::serialize):
(WebCore::CloneSerializer::CloneSerializer):
(WebCore::CloneDeserializer::deserializeString):
(WebCore::CloneDeserializer::deserialize):
(WebCore::CloneDeserializer::isValid const):
(WebCore::CloneDeserializer::shouldRetryWithVersionUpgrade):
(WebCore::CloneDeserializer::upgradeVersion):
(WebCore::CloneDeserializer::read):
(WebCore::CloneDeserializer::readFile):
(WebCore::CloneDeserializer::readArrayBuffer):
(WebCore::CloneDeserializer::readArrayBufferView):
(WebCore::CloneDeserializer::readImageBitmap):
(WebCore::CloneDeserializer::readTerminal):
(WebCore::CloneDeserializer::version const): Deleted.
(WebCore::SerializedScriptValue::wireFormatVersion): Deleted.
* Source/WebCore/bindings/js/SerializedScriptValue.h:

Canonical link: https://commits.webkit.org/267815.665@safari-7617.2.4.10-branch

  Commit: acd97b1d6ae1896c8ccaf64224c279b479fd9819
      https://github.com/WebKit/WebKit/commit/acd97b1d6ae1896c8ccaf64224c279b479fd9819
  Author: Myah Cobbs <mcobbs at apple.com>
  Date:   2024-01-03 (Wed, 03 Jan 2024)

  Changed paths:
    M Source/WebCore/bindings/js/SerializedScriptValue.cpp
    M Source/WebCore/bindings/js/SerializedScriptValue.h

  Log Message:
  -----------
  Revert "Safari's IndexedDB data may not be deserialized correctly after system upgrades"

This reverts commit c3c2a42ade132ffa93ed351556aea716de47c358.

Identifier: 267815.666 at safari-7617.2.4.10-branch

  Commit: 0e81bda6c87cf20e62346b417388f7102790add1
      https://github.com/WebKit/WebKit/commit/0e81bda6c87cf20e62346b417388f7102790add1
  Author: Dan Robson <dtr_bugzilla at apple.com>
  Date:   2024-01-05 (Fri, 05 Jan 2024)

  Changed paths:
    M Configurations/Version.xcconfig

  Log Message:
  -----------
  Versioning.

WebKit-617.2.4.10.6

Canonical link: https://commits.webkit.org/267815.667@safari-7617.2.4.10-branch

  Commit: 186a76558dc941735ddc0b624e5f6ad633fff05f
      https://github.com/WebKit/WebKit/commit/186a76558dc941735ddc0b624e5f6ad633fff05f
  Author: Dan Robson <dtr_bugzilla at apple.com>
  Date:   2024-01-05 (Fri, 05 Jan 2024)

  Changed paths:
    M Source/JavaScriptCore/dfg/DFGGraph.cpp

  Log Message:
  -----------
  Apply patch. rdar://120560288

Canonical link: https://commits.webkit.org/267815.668@safari-7617.2.4.10-branch

  Commit: 81a60d7b2a6affca49e8bf29aeac38d2ea390572
      https://github.com/WebKit/WebKit/commit/81a60d7b2a6affca49e8bf29aeac38d2ea390572
  Author: Myah Cobbs <mcobbs at apple.com>
  Date:   2024-01-10 (Wed, 10 Jan 2024)

  Changed paths:
    M Configurations/Version.xcconfig

  Log Message:
  -----------
  Versioning.

WebKit-7617.2.4.10.7

Identifier: 267815.669 at safari-7617.2.4.10-branch

  Commit: 478c5c3e6a27467713e8c1226a2ccb331d7af0ba
      https://github.com/WebKit/WebKit/commit/478c5c3e6a27467713e8c1226a2ccb331d7af0ba
  Author: Dan Robson <dtr_bugzilla at apple.com>
  Date:   2024-01-25 (Thu, 25 Jan 2024)

  Changed paths:
    M Configurations/Version.xcconfig

  Log Message:
  -----------
  Versioning.

WebKit-617.2.4.10.8

Canonical link: https://commits.webkit.org/267815.670@safari-7617.2.4.10-branch

  Commit: 67e442a2143ad0c8f2b8385f1e44d1c6768088a7
      https://github.com/WebKit/WebKit/commit/67e442a2143ad0c8f2b8385f1e44d1c6768088a7
  Author: Myah Cobbs <mcobbs at apple.com>
  Date:   2024-01-25 (Thu, 25 Jan 2024)

  Changed paths:
    M Source/WebCore/Headers.cmake
    M Source/WebCore/Sources.txt
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayBox.h
    M Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContent.cpp
    M Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContent.cpp
    M Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContent.h
    M Source/WebCore/rendering/GlyphDisplayListCache.cpp
    M Source/WebCore/rendering/GlyphDisplayListCache.h
    A Source/WebCore/rendering/GlyphDisplayListCacheRemoval.cpp
    A Source/WebCore/rendering/GlyphDisplayListCacheRemoval.h
    M Source/WebCore/rendering/LegacyInlineBox.h
    M Source/WebCore/rendering/LegacyInlineTextBox.cpp
    M Source/WebCore/rendering/LegacyInlineTextBox.h
    M Source/WebCore/rendering/ReferencedSVGResources.cpp
    M Source/WebCore/rendering/TextPainter.h
    M Source/WebCore/rendering/svg/RenderSVGResource.h
    M Source/WebCore/rendering/updating/RenderTreeBuilderList.cpp

  Log Message:
  -----------
  Apply patch. rdar://121602957

Identifier: 267815.671 at safari-7617.2.4.10-branch

Compare: https://github.com/WebKit/WebKit/compare/a1b3b9269e4a%5E...67e442a2143a

To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications