[webkit-changes] [WebKit/WebKit] df4f81: [Navigation] Consolidate "document is fully active...

[Rob Buis]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: df4f8114adb94520ac83c8a0b0d8b4aaba7e1028
      https://github.com/WebKit/WebKit/commit/df4f8114adb94520ac83c8a0b0d8b4aaba7e1028
  Author: Rob Buis <rbuis at igalia.com>
  Date:   2024-05-10 (Fri, 10 May 2024)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/navigate-rejection-order-detached-unserializablestate-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/navigate-rejection-order-invalidurl-detached-expected.txt
    M Source/WebCore/page/Navigation.cpp

  Log Message:
  -----------
  [Navigation] Consolidate "document is fully active" check in navigate
https://bugs.webkit.org/show_bug.cgi?id=273972

Reviewed by Alex Christensen.

The navigate method starts of by (partly) checking whether the document is fully active by
checking that the frame exists, however the "document is fully active" check should be done
in step 7 (see [1]). So remove the frame check and rely on the later call to isFullyActive
to get the correct order of handling possible errors.

[1] https://html.spec.whatwg.org/multipage/nav-history-apis.html#dom-navigation-navigate

* LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/navigate-rejection-order-detached-unserializablestate-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/navigation-api/navigation-methods/return-value/navigate-rejection-order-invalidurl-detached-expected.txt:
* Source/WebCore/page/Navigation.cpp:
(WebCore::Navigation::navigate):

Canonical link: https://commits.webkit.org/278627@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications