[webkit-changes] [WebKit/WebKit] fffbee: Classify BreakLines.h

fantasai noreply at github.com
Fri May 10 13:42:20 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fffbee3095b662f425cda421a17c26620e1e363a
      https://github.com/WebKit/WebKit/commit/fffbee3095b662f425cda421a17c26620e1e363a
  Author: Elika Etemad <fantasai.bugs at inkedblade.net>
  Date:   2024-05-10 (Fri, 10 May 2024)

  Changed paths:
    M Source/WebCore/layout/formattingContexts/inline/text/TextUtil.cpp
    M Source/WebCore/rendering/BreakLines.cpp
    M Source/WebCore/rendering/BreakLines.h
    M Source/WebCore/rendering/RenderText.cpp
    M Source/WebCore/rendering/line/BreakingContext.h
    M Source/WebKitLegacy/ios/Misc/WebUIKitSupport.mm

  Log Message:
  -----------
  Classify BreakLines.h
https://bugs.webkit.org/show_bug.cgi?id=273729
rdar://127532669

Reviewed by Alan Baradlay.

Organize BreakLines.h functions and data into classes to namespace them
and to mark non-public items as private.

* Source/WebCore/layout/formattingContexts/inline/text/TextUtil.cpp:
(WebCore::Layout::TextUtil::findNextBreakablePosition):
* Source/WebCore/rendering/BreakLines.cpp:
(WebCore:::m_table):
* Source/WebCore/rendering/BreakLines.h:
(WebCore::BreakLines::nextBreakablePosition):
(WebCore::BreakLines::LineBreakTable::unsafeLookup const):
(WebCore::BreakLines::isBreakableSpace):
(WebCore::BreakLines::nextBreakableSpace):
(WebCore::BreakLines::nextCharacter):
(WebCore::BreakLines::isBreakable):
(WebCore::nextBreakablePosition): Deleted.
(WebCore::lineBreakTableUnsafeLookup): Deleted.
(WebCore::isBreakableSpace): Deleted.
(WebCore::nextBreakableSpace): Deleted.
(WebCore::nextCharacter): Deleted.
(WebCore::isBreakable): Deleted.
* Source/WebCore/rendering/RenderText.cpp:
(WebCore::RenderText::computePreferredLogicalWidths):
* Source/WebCore/rendering/line/BreakingContext.h:
(WebCore::BreakingContext::handleText):
* Source/WebKitLegacy/ios/Misc/WebUIKitSupport.mm:
(WebKitGetLastLineBreakInBuffer):

Canonical link: https://commits.webkit.org/278626@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list