[webkit-changes] [WebKit/WebKit] a32d21: [WGSL] AttributeValidator derefs a nullptr return ...

Tadeu Zagallo noreply at github.com
Wed May 8 04:20:02 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a32d219bdf05c2f2eb7bff03c13781fa31e83eaa
      https://github.com/WebKit/WebKit/commit/a32d219bdf05c2f2eb7bff03c13781fa31e83eaa
  Author: Tadeu Zagallo <tzagallo at apple.com>
  Date:   2024-05-08 (Wed, 08 May 2024)

  Changed paths:
    M Source/WebGPU/WGSL/AttributeValidator.cpp

  Log Message:
  -----------
  [WGSL] AttributeValidator derefs a nullptr return type
https://bugs.webkit.org/show_bug.cgi?id=273837
rdar://127182544

Reviewed by Mike Wyrzykowski.

The UB sanitizer caught that we unconditionally deref the function's return
type in the AttributeValidator. The fix is to simply guard it by checking if
the function actually has a return type.

* Source/WebGPU/WGSL/AttributeValidator.cpp:
(WGSL::AttributeValidator::visit):

Canonical link: https://commits.webkit.org/278503@main



To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications


More information about the webkit-changes mailing list