[webkit-changes] [WebKit/WebKit] 701053: Cherry-pick 277550 at main (6d4b28213caf). https://bu...

[Chris Dumez]

  Branch: refs/heads/webkitglib/2.44
  Home:   https://github.com/WebKit/WebKit
  Commit: 701053d081ee7ff42f98014d716f65c09ffbdf88
      https://github.com/WebKit/WebKit/commit/701053d081ee7ff42f98014d716f65c09ffbdf88
  Author: Antti Koivisto <antti at apple.com>
  Date:   2024-05-08 (Wed, 08 May 2024)

  Changed paths:
    A LayoutTests/fast/block/positioning/simple-out-of-flow-parent-relative-expected.html
    A LayoutTests/fast/block/positioning/simple-out-of-flow-parent-relative.html
    R LayoutTests/fast/block/positioning/simple-out-of-flow-percent-height-expected.html
    R LayoutTests/fast/block/positioning/simple-out-of-flow-percent-height.html
    M Source/WebCore/rendering/RenderBlockFlow.cpp

  Log Message:
  -----------
  Cherry-pick 277550 at main (6d4b28213caf). https://bugs.webkit.org/show_bug.cgi?id=272479

    REGRESSION (271848 at main): Incorrect position of ::before { position:absolute; bottom:0} dynamically changing content
    https://bugs.webkit.org/show_bug.cgi?id=272479
    rdar://126234450

    Reviewed by Alan Baradlay.

    This is similar to the earlier issue https://bugs.webkit.org/show_bug.cgi?id=272665. Here the bottom is fixed
    and top is auto making it relative to the parent height.

    * LayoutTests/fast/block/positioning/simple-out-of-flow-parent-relative-expected.html: Renamed from LayoutTests/fast/block/positioning/simple-out-of-flow-percent-height-expected.html.
    * LayoutTests/fast/block/positioning/simple-out-of-flow-parent-relative.html: Renamed from LayoutTests/fast/block/positioning/simple-out-of-flow-percent-height.html.

    Expand the test case.

    * Source/WebCore/rendering/RenderBlockFlow.cpp:
    (WebCore::RenderBlockFlow::layoutModernLines):

    Cover percent top and non-auto bottom cases too.

    Canonical link: https://commits.webkit.org/277550@main

Canonical link: https://commits.webkit.org/274313.206@webkitglib/2.44


  Commit: 51fc8c8171727331c21085c498fb68c806fd8573
      https://github.com/WebKit/WebKit/commit/51fc8c8171727331c21085c498fb68c806fd8573
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2024-05-08 (Wed, 08 May 2024)

  Changed paths:
    M Source/WebKit/WebProcess/WebCoreSupport/mac/WebAlternativeTextClient.cpp

  Log Message:
  -----------
  Cherry-pick 277440 at main (224cac4b7170). https://bugs.webkit.org/show_bug.cgi?id=272601

    Crash under ~WebAlternativeTextClient() when closing Safari window while paused in debugger
    https://bugs.webkit.org/show_bug.cgi?id=272601
    rdar://125689132

    Reviewed by Ryosuke Niwa.

    Null check `m_page` since it is a WeakPtr.

    * Source/WebKit/WebProcess/WebCoreSupport/mac/WebAlternativeTextClient.cpp:
    (WebKit::WebAlternativeTextClient::WebAlternativeTextClient):
    (WebKit::WebAlternativeTextClient::~WebAlternativeTextClient):

    Canonical link: https://commits.webkit.org/277440@main

Canonical link: https://commits.webkit.org/274313.207@webkitglib/2.44


Compare: https://github.com/WebKit/WebKit/compare/049054f9efcb...51fc8c817172

To unsubscribe from these emails, change your notification settings at https://github.com/WebKit/WebKit/settings/notifications